You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Bjoern A. Zeeb" <bz...@lists.zabbadoz.net> on 2003/03/13 20:49:14 UTC

need to read error_logs from httpd ?

Hi,

is there a need that we open error_log for reading from within httpd ?


--- httpd-2.0/server/log.c.orig	Thu Mar 13 19:47:20 2003
+++ httpd-2.0/server/log.c	Thu Mar 13 19:47:48 2003
@@ -313,7 +313,7 @@
             return DONE;
         }
         if ((rc = apr_file_open(&s->error_log, fname,
-                               APR_APPEND | APR_READ | APR_WRITE | APR_CREATE,
+                               APR_APPEND | APR_WRITE | APR_CREATE,
                                APR_OS_DEFAULT, p)) != APR_SUCCESS) {
             ap_log_error(APLOG_MARK, APLOG_STARTUP, rc, NULL,
                          "%s: could not open error log file %s.",

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/

Re: need to read error_logs from httpd ?

Posted by Jeff Trawick <tr...@attglobal.net>.
Bjoern A. Zeeb wrote:

> is there a need that we open error_log for reading from within httpd ?
> 
> 
> --- httpd-2.0/server/log.c.orig	Thu Mar 13 19:47:20 2003
> +++ httpd-2.0/server/log.c	Thu Mar 13 19:47:48 2003
> @@ -313,7 +313,7 @@
>              return DONE;
>          }
>          if ((rc = apr_file_open(&s->error_log, fname,
> -                               APR_APPEND | APR_READ | APR_WRITE | APR_CREATE,
> +                               APR_APPEND | APR_WRITE | APR_CREATE,

patch finally committed to 2.1-dev, along with the same change in 
another path


Re: need to read error_logs from httpd ?

Posted by Jeff Trawick <tr...@attglobal.net>.
I don't think so.  And there is another error-log-open path that should 
be fixed too.