You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by oleersoy <gi...@git.apache.org> on 2014/09/30 02:09:44 UTC

[GitHub] commons-math pull request: Updated the example documentation for t...

GitHub user oleersoy opened a pull request:

    https://github.com/apache/commons-math/pull/4

    Updated the example documentation for the GaussianCurveFitte

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oleersoy/commons-math trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-math/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 5f7ef4d1ba971086b5e892654175478b7e30917f
Author: Ole <ol...@gmail.com>
Date:   2014-09-29T23:56:41Z

    Updated the example documentation for the GaussianCurveFitte

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
Gilles, Luke, Phil,

I respect what you are saying.  All I'm saying is that I think using Git to it's full potential will be more attractive and less confusing to future contributors.  I'm really not trying to lobby strongly for this though.  I just shared my thoughts on it in case the move to github triggers others to start asking the types of questions / comments that we just saw.

Cheers,
- Ole

On 10/03/2014 06:42 AM, Luc Maisonobe wrote:
> Hi all,
>
> Le 03/10/2014 12:17, Gilles a écrit :
>> Hi.
>>
>> On Thu, 02 Oct 2014 15:35:53 -0500, Ole Ersoy wrote:
>>> On 10/02/2014 02:18 PM, Phil Steitz wrote:
>>>> On 10/2/14 11:33 AM, Ole Ersoy wrote:
>>>>> Hi,
>>>>>
>>>>> On 10/02/2014 11:34 AM, Gilles wrote:
>>>>>> Hello.
>>>>>>
>>>>>> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>>>>>>> Hello Luc, Gilles, and Benedikt,
>>>>>>>
>>>>>>> I'm here :).  From my limited github experience, I do think most
>>>>>>> contributors do their communication directly through github.
>>>>>>
>>>>>> "Commons" contributors?
>>>>>
>>>>> I should have clarified.  Just github users and contributors in
>>>>> general.  A popular pattern I see for github repository projects
>>>>> is that developers keep their pull communication with the pull,
>>>>> design (etc.) discussions in issues, and support on
>>>>> stackoverflow.  So I'm thinking that future / potential
>>>>> commons-math contributors might expect this type of pattern.
>>>>>
>>>>>>
>>>>>>> I've
>>>>>>> seen a lot of projects use issues for discussion.  I personally
>>>>>>> like
>>>>>>> this, because it makes it easy to get up to speed on design
>>>>>>> decisions
>>>>>>> and project history.
>>>>>>
>>>>>> Perhaps it's a better way.  But it's not (yet) the official way,
>>>>>> which
>>>>>> is this ML.
>>>>>
>>>>> Sure.  I just wanted to mention it since github users that are
>>>>> watching the project will get more information without having to
>>>>> subscribe to the mailing list.
>>>>>
>>>>> Also I think what Benedikt was saying was that I might be someone
>>>>> who does not actually know about the mailing list, so if
>>>>> communication goes out to me on the mailing list WRT my pull
>>>>> request, I might miss it.
>>>>
>>>> The problem is that if any substantial design discussion happens
>>>> *outside* the ML, those who *are* subscribed to the list will miss
>>>> *that*.
>>>
>>> Sure - but in all fairness, it's as simple as going to the github
>>> repository and clicking watch.  The other benefit is that now the
>>> notifications will be for commons math only.
>>
>> ?
>> We _have_ to be subscribed on this ML to contribute to this project.
>> Thus we get all the (not necessarily interesting to everyone) posted
>> here, and _in addition_ we would get message from yet another source.
>> That's no improvement. Unless things have to get to get worse before
>> they get better. ;-)

>>
>>>
>>>> A core principle of ASF projects is that everything
>>>> happens in the open, is archived and easily accessible to anyone
>>>> interested in getting involved in a project.
>>>
>>> This will become even more true if github issues are used.  From a
>>> reading perspective the github format is cleaner looking than
>>> markmail, etc.
>>
>> IMHO, the readability of the archive is not the most important point.
>> It is there for reference purpose. Questions are: Where is the "official"
>> record of the project and where do discussions and decisions take place?
>> The current answer is "here".
>>
>>>
>>>> The "if it did not
>>>> happen on the list, it did not happen" principle is really just to
>>>> ensure that.  If we start having design discussions outside the
>>>> list, to figure out what is going on / has gone on, people will have
>>>> to go looking around the internet, rather than just looking at the
>>>> list archives.
>>>
>>> Everything is tied to the repository.  All the information is in one
>>> place.  That's usually a plus.
>>
>> Only if we drop everything that would be a duplicate of the functionality
>> available on that other forum.
>>
>>>
>>>> This is one reason we have traditionally liked to
>>>> have design discussions on the list, rather than in JIRA tickets and
>>>> why JIRA comments are in any case forwarded to the list.
>>>
>>> Sure - honestly I'm just trying to be helpful and suggest a few
>>> things that will make things even simpler while improving the utility,
>>> uniform accessibility, visibility, and marketability of commons math
>>> activity.
>>
>> Thanks for trying to help. However, you might have more luck to create
>> things that do not exist yet rather than try and change what exists.
>> [From my own experience. :-} ]
>>
>>> Since git is a more social platform, it may make sense to
>>> take advantage of more of its features.
>>
>> In practice, you may be right; but in principle, I don't agree.
>> "git" provides the means to decentralize while "github" is by essence
>> a centralizer.
>
> There are two separate things: discussing features and providing patches.
>
> Discussion must be on the list. This is Apache way of doing things and
> it is where people will look at. It is one of the few things that are
> mandatory at Apache. Someone said once: "if it didn't happen on the
> mailing list, it didn't happen" (most probably one of Apache early
> founders).
>
> Git and its decentralized aspects improve on how contributors can
> provide patches. They can experiment ont their own development setup,
> and once they are happy with it they can trigger a pull request. I
> sincerely think this is really a good thing and it allows these people
> tog et involved more quickly. It also seems more fair to me since Git
> allow to have a separate author and committer, so new contributors get
> the credit they deserve more efficiently than with subversion, where
> only the committer name is automatically preserved.
>
> So you can for sure use GitHub for the pull request, it's great!
> However, the mailing list remains the main discussion place.
>
> best regards,
> Luc
>
>>
>>
>> Best regards,
>> Gilles
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Luc Maisonobe <lu...@spaceroots.org>.
Hi all,

Le 03/10/2014 12:17, Gilles a écrit :
> Hi.
> 
> On Thu, 02 Oct 2014 15:35:53 -0500, Ole Ersoy wrote:
>> On 10/02/2014 02:18 PM, Phil Steitz wrote:
>>> On 10/2/14 11:33 AM, Ole Ersoy wrote:
>>>> Hi,
>>>>
>>>> On 10/02/2014 11:34 AM, Gilles wrote:
>>>>> Hello.
>>>>>
>>>>> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>>>>>> Hello Luc, Gilles, and Benedikt,
>>>>>>
>>>>>> I'm here :).  From my limited github experience, I do think most
>>>>>> contributors do their communication directly through github.
>>>>>
>>>>> "Commons" contributors?
>>>>
>>>> I should have clarified.  Just github users and contributors in
>>>> general.  A popular pattern I see for github repository projects
>>>> is that developers keep their pull communication with the pull,
>>>> design (etc.) discussions in issues, and support on
>>>> stackoverflow.  So I'm thinking that future / potential
>>>> commons-math contributors might expect this type of pattern.
>>>>
>>>>>
>>>>>> I've
>>>>>> seen a lot of projects use issues for discussion.  I personally
>>>>>> like
>>>>>> this, because it makes it easy to get up to speed on design
>>>>>> decisions
>>>>>> and project history.
>>>>>
>>>>> Perhaps it's a better way.  But it's not (yet) the official way,
>>>>> which
>>>>> is this ML.
>>>>
>>>> Sure.  I just wanted to mention it since github users that are
>>>> watching the project will get more information without having to
>>>> subscribe to the mailing list.
>>>>
>>>> Also I think what Benedikt was saying was that I might be someone
>>>> who does not actually know about the mailing list, so if
>>>> communication goes out to me on the mailing list WRT my pull
>>>> request, I might miss it.
>>>
>>> The problem is that if any substantial design discussion happens
>>> *outside* the ML, those who *are* subscribed to the list will miss
>>> *that*.
>>
>> Sure - but in all fairness, it's as simple as going to the github
>> repository and clicking watch.  The other benefit is that now the
>> notifications will be for commons math only.
> 
> ?
> We _have_ to be subscribed on this ML to contribute to this project.
> Thus we get all the (not necessarily interesting to everyone) posted
> here, and _in addition_ we would get message from yet another source.
> That's no improvement. Unless things have to get to get worse before
> they get better. ;-)
> 
>>
>>> A core principle of ASF projects is that everything
>>> happens in the open, is archived and easily accessible to anyone
>>> interested in getting involved in a project.
>>
>> This will become even more true if github issues are used.  From a
>> reading perspective the github format is cleaner looking than
>> markmail, etc.
> 
> IMHO, the readability of the archive is not the most important point.
> It is there for reference purpose. Questions are: Where is the "official"
> record of the project and where do discussions and decisions take place?
> The current answer is "here".
> 
>>
>>> The "if it did not
>>> happen on the list, it did not happen" principle is really just to
>>> ensure that.  If we start having design discussions outside the
>>> list, to figure out what is going on / has gone on, people will have
>>> to go looking around the internet, rather than just looking at the
>>> list archives.
>>
>> Everything is tied to the repository.  All the information is in one
>> place.  That's usually a plus.
> 
> Only if we drop everything that would be a duplicate of the functionality
> available on that other forum.
> 
>>
>>> This is one reason we have traditionally liked to
>>> have design discussions on the list, rather than in JIRA tickets and
>>> why JIRA comments are in any case forwarded to the list.
>>
>> Sure - honestly I'm just trying to be helpful and suggest a few
>> things that will make things even simpler while improving the utility,
>> uniform accessibility, visibility, and marketability of commons math
>> activity.
> 
> Thanks for trying to help. However, you might have more luck to create
> things that do not exist yet rather than try and change what exists.
> [From my own experience. :-} ]
> 
>> Since git is a more social platform, it may make sense to
>> take advantage of more of its features.
> 
> In practice, you may be right; but in principle, I don't agree.
> "git" provides the means to decentralize while "github" is by essence
> a centralizer.

There are two separate things: discussing features and providing patches.

Discussion must be on the list. This is Apache way of doing things and
it is where people will look at. It is one of the few things that are
mandatory at Apache. Someone said once: "if it didn't happen on the
mailing list, it didn't happen" (most probably one of Apache early
founders).

Git and its decentralized aspects improve on how contributors can
provide patches. They can experiment ont their own development setup,
and once they are happy with it they can trigger a pull request. I
sincerely think this is really a good thing and it allows these people
tog et involved more quickly. It also seems more fair to me since Git
allow to have a separate author and committer, so new contributors get
the credit they deserve more efficiently than with subversion, where
only the committer name is automatically preserved.

So you can for sure use GitHub for the pull request, it's great!
However, the mailing list remains the main discussion place.

best regards,
Luc

> 
> 
> Best regards,
> Gilles
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Gilles <gi...@harfang.homelinux.org>.
Hi.

On Thu, 02 Oct 2014 15:35:53 -0500, Ole Ersoy wrote:
> On 10/02/2014 02:18 PM, Phil Steitz wrote:
>> On 10/2/14 11:33 AM, Ole Ersoy wrote:
>>> Hi,
>>>
>>> On 10/02/2014 11:34 AM, Gilles wrote:
>>>> Hello.
>>>>
>>>> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>>>>> Hello Luc, Gilles, and Benedikt,
>>>>>
>>>>> I'm here :).  From my limited github experience, I do think most
>>>>> contributors do their communication directly through github.
>>>>
>>>> "Commons" contributors?
>>>
>>> I should have clarified.  Just github users and contributors in
>>> general.  A popular pattern I see for github repository projects
>>> is that developers keep their pull communication with the pull,
>>> design (etc.) discussions in issues, and support on
>>> stackoverflow.  So I'm thinking that future / potential
>>> commons-math contributors might expect this type of pattern.
>>>
>>>>
>>>>> I've
>>>>> seen a lot of projects use issues for discussion.  I personally
>>>>> like
>>>>> this, because it makes it easy to get up to speed on design
>>>>> decisions
>>>>> and project history.
>>>>
>>>> Perhaps it's a better way.  But it's not (yet) the official way,
>>>> which
>>>> is this ML.
>>>
>>> Sure.  I just wanted to mention it since github users that are
>>> watching the project will get more information without having to
>>> subscribe to the mailing list.
>>>
>>> Also I think what Benedikt was saying was that I might be someone
>>> who does not actually know about the mailing list, so if
>>> communication goes out to me on the mailing list WRT my pull
>>> request, I might miss it.
>>
>> The problem is that if any substantial design discussion happens
>> *outside* the ML, those who *are* subscribed to the list will miss
>> *that*.
>
> Sure - but in all fairness, it's as simple as going to the github
> repository and clicking watch.  The other benefit is that now the
> notifications will be for commons math only.

?
We _have_ to be subscribed on this ML to contribute to this project.
Thus we get all the (not necessarily interesting to everyone) posted
here, and _in addition_ we would get message from yet another source.
That's no improvement. Unless things have to get to get worse before
they get better. ;-)

>
>> A core principle of ASF projects is that everything
>> happens in the open, is archived and easily accessible to anyone
>> interested in getting involved in a project.
>
> This will become even more true if github issues are used.  From a
> reading perspective the github format is cleaner looking than
> markmail, etc.

IMHO, the readability of the archive is not the most important point.
It is there for reference purpose. Questions are: Where is the 
"official"
record of the project and where do discussions and decisions take 
place?
The current answer is "here".

>
>> The "if it did not
>> happen on the list, it did not happen" principle is really just to
>> ensure that.  If we start having design discussions outside the
>> list, to figure out what is going on / has gone on, people will have
>> to go looking around the internet, rather than just looking at the
>> list archives.
>
> Everything is tied to the repository.  All the information is in one
> place.  That's usually a plus.

Only if we drop everything that would be a duplicate of the 
functionality
available on that other forum.

>
>> This is one reason we have traditionally liked to
>> have design discussions on the list, rather than in JIRA tickets and
>> why JIRA comments are in any case forwarded to the list.
>
> Sure - honestly I'm just trying to be helpful and suggest a few
> things that will make things even simpler while improving the 
> utility,
> uniform accessibility, visibility, and marketability of commons math
> activity.

Thanks for trying to help. However, you might have more luck to create
things that do not exist yet rather than try and change what exists.
[From my own experience. :-} ]

> Since git is a more social platform, it may make sense to
> take advantage of more of its features.

In practice, you may be right; but in principle, I don't agree.
"git" provides the means to decentralize while "github" is by essence
a centralizer.


Best regards,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.

On 10/02/2014 02:18 PM, Phil Steitz wrote:
> On 10/2/14 11:33 AM, Ole Ersoy wrote:
>> Hi,
>>
>> On 10/02/2014 11:34 AM, Gilles wrote:
>>> Hello.
>>>
>>> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>>>> Hello Luc, Gilles, and Benedikt,
>>>>
>>>> I'm here :).  From my limited github experience, I do think most
>>>> contributors do their communication directly through github.
>>>
>>> "Commons" contributors?
>>
>> I should have clarified.  Just github users and contributors in
>> general.  A popular pattern I see for github repository projects
>> is that developers keep their pull communication with the pull,
>> design (etc.) discussions in issues, and support on
>> stackoverflow.  So I'm thinking that future / potential
>> commons-math contributors might expect this type of pattern.
>>
>>>
>>>> I've
>>>> seen a lot of projects use issues for discussion.  I personally
>>>> like
>>>> this, because it makes it easy to get up to speed on design
>>>> decisions
>>>> and project history.
>>>
>>> Perhaps it's a better way.  But it's not (yet) the official way,
>>> which
>>> is this ML.
>>
>> Sure.  I just wanted to mention it since github users that are
>> watching the project will get more information without having to
>> subscribe to the mailing list.
>>
>> Also I think what Benedikt was saying was that I might be someone
>> who does not actually know about the mailing list, so if
>> communication goes out to me on the mailing list WRT my pull
>> request, I might miss it.
>
> The problem is that if any substantial design discussion happens
> *outside* the ML, those who *are* subscribed to the list will miss
> *that*.

Sure - but in all fairness, it's as simple as going to the github repository and clicking watch.  The other benefit is that now the notifications will be for commons math only.

> A core principle of ASF projects is that everything
> happens in the open, is archived and easily accessible to anyone
> interested in getting involved in a project.

This will become even more true if github issues are used.  From a reading perspective the github format is cleaner looking than markmail, etc.

> The "if it did not
> happen on the list, it did not happen" principle is really just to
> ensure that.  If we start having design discussions outside the
> list, to figure out what is going on / has gone on, people will have
> to go looking around the internet, rather than just looking at the
> list archives.

Everything is tied to the repository.  All the information is in one place.  That's usually a plus.

> This is one reason we have traditionally liked to
> have design discussions on the list, rather than in JIRA tickets and
> why JIRA comments are in any case forwarded to the list.

Sure - honestly I'm just trying to be helpful and suggest a few things that will make things even simpler while improving the utility, uniform accessibility, visibility, and marketability of commons math activity.  Since git is a more social platform, it may make sense to take advantage of more of its features.

Cheers,
- Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Phil Steitz <ph...@gmail.com>.
On 10/2/14 11:33 AM, Ole Ersoy wrote:
> Hi,
>
> On 10/02/2014 11:34 AM, Gilles wrote:
>> Hello.
>>
>> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>>> Hello Luc, Gilles, and Benedikt,
>>>
>>> I'm here :).  From my limited github experience, I do think most
>>> contributors do their communication directly through github.
>>
>> "Commons" contributors?
>
> I should have clarified.  Just github users and contributors in
> general.  A popular pattern I see for github repository projects
> is that developers keep their pull communication with the pull,
> design (etc.) discussions in issues, and support on
> stackoverflow.  So I'm thinking that future / potential
> commons-math contributors might expect this type of pattern.
>
>>
>>> I've
>>> seen a lot of projects use issues for discussion.  I personally
>>> like
>>> this, because it makes it easy to get up to speed on design
>>> decisions
>>> and project history.
>>
>> Perhaps it's a better way.  But it's not (yet) the official way,
>> which
>> is this ML.
>
> Sure.  I just wanted to mention it since github users that are
> watching the project will get more information without having to
> subscribe to the mailing list.
>
> Also I think what Benedikt was saying was that I might be someone
> who does not actually know about the mailing list, so if
> communication goes out to me on the mailing list WRT my pull
> request, I might miss it.

The problem is that if any substantial design discussion happens
*outside* the ML, those who *are* subscribed to the list will miss
*that*.   A core principle of ASF projects is that everything
happens in the open, is archived and easily accessible to anyone
interested in getting involved in a project.  The "if it did not
happen on the list, it did not happen" principle is really just to
ensure that.  If we start having design discussions outside the
list, to figure out what is going on / has gone on, people will have
to go looking around the internet, rather than just looking at the
list archives.  This is one reason we have traditionally liked to
have design discussions on the list, rather than in JIRA tickets and
why JIRA comments are in any case forwarded to the list.

Phil


>
> Cheers,
> - Ole
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
Hi,

On 10/02/2014 11:34 AM, Gilles wrote:
> Hello.
>
> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
>> Hello Luc, Gilles, and Benedikt,
>>
>> I'm here :).  From my limited github experience, I do think most
>> contributors do their communication directly through github.
>
> "Commons" contributors?

I should have clarified.  Just github users and contributors in general.  A popular pattern I see for github repository projects is that developers keep their pull communication with the pull, design (etc.) discussions in issues, and support on stackoverflow.  So I'm thinking that future / potential commons-math contributors might expect this type of pattern.

>
>> I've
>> seen a lot of projects use issues for discussion.  I personally like
>> this, because it makes it easy to get up to speed on design decisions
>> and project history.
>
> Perhaps it's a better way.  But it's not (yet) the official way, which
> is this ML.

Sure.  I just wanted to mention it since github users that are watching the project will get more information without having to subscribe to the mailing list.

Also I think what Benedikt was saying was that I might be someone who does not actually know about the mailing list, so if communication goes out to me on the mailing list WRT my pull request, I might miss it.

Cheers,
- Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Gilles <gi...@harfang.homelinux.org>.
Hello.

On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote:
> Hello Luc, Gilles, and Benedikt,
>
> I'm here :).  From my limited github experience, I do think most
> contributors do their communication directly through github.

"Commons" contributors?

> I've
> seen a lot of projects use issues for discussion.  I personally like
> this, because it makes it easy to get up to speed on design decisions
> and project history.

Perhaps it's a better way.  But it's not (yet) the official way, which
is this ML.


Best regards,
Gilles

> [...]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Emmanuel Bourg <eb...@apache.org>.
Le 03/10/2014 16:46, Ole Ersoy a écrit :
> Ooops - Sorry Luc, slight mental glitch there - I wrote Luke instead of
> Luc :).

Use git push --force, Luc :)

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
Ooops - Sorry Luc, slight mental glitch there - I wrote Luke instead of Luc :).

Cheers,
- Ole


On 10/03/2014 06:46 AM, Luc Maisonobe wrote:
> Le 02/10/2014 17:51, Ole Ersoy a écrit :
>> Hello Luc, Gilles, and Benedikt,
>>
>> I'm here :).  From my limited github experience, I do think most
>> contributors do their communication directly through github.  I've seen
>> a lot of projects use issues for discussion.  I personally like this,
>> because it makes it easy to get up to speed on design decisions and
>> project history.
>>
>> Thanks for letting me know about the differences.  I'll create a new
>> fork for any future updates.  I'm surprised that there are differences
>> because I did the fork very recently and only made one small change in
>> vi before performing the push and pull request.  I only changed that one
>> file.
>
> The reason there is a difference is that the GitHub mirror was based on
> an early git mirror when our main repository was subversion. We have
> switched to Git only a few weeks ago, and the official original git
> repository has been recreated from the subversion history, not from the
> other git mirror. This means that the commits have been recreated when
> the migration was done, and the hashed are different, despite the
> content of each commit is the same. See
> <https://issues.apache.org/jira/browse/INFRA-8419>.
>
> best regards,
> Luc
>
>>
>> Cheers,
>> - Ole
>>
>> On 10/02/2014 05:03 AM, Gilles wrote:
>>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>>> Hi Luc,
>>>>
>>>> this emails are outgenerated when a PR is created at github, so I
>>>> wouldn't
>>>> expect the contributor to be subscribed to the list. It's probably
>>>> better
>>>> to comment on the PR at github.
>>>
>>> Sorry to intervene; but why is it better to bypass this list?
>>> Isn't it expected that a contibutor is subscribed to the project's ML,
>>> and not only to a forum built around one of the development tools?
>>>
>>> Best regards,
>>> Gilles
>>>
>>>>
>>>> Benedikt
>>>>
>>>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>>>
>>>>> Hi Ole,
>>>>>
>>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>>
>>>>>> GitHub user oleersoy opened a pull request:
>>>>>>
>>>>>>      https://github.com/apache/commons-math/pull/4
>>>>>>
>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>
>>>>>>
>>>>>>
>>>>>> You can merge this pull request into a Git repository by running:
>>>>>>
>>>>>>      $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>>
>>>>>> Alternatively you can review and apply these changes as the patch at:
>>>>>>
>>>>>>      https://github.com/apache/commons-math/pull/4.patch
>>>>>>
>>>>>> To close this pull request, make a commit to your master/trunk branch
>>>>>> with (at least) the following in the commit message:
>>>>>>
>>>>>>      This closes #4
>>>>>>
>>>>>
>>>>>
>>>>> I have reviewed and committed the patch.
>>>>>
>>>>> Beware that your GitHub repository seem to have a lot of differences
>>>>> from
>>>>> our
>>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>>> lot
>>>>> of conflicts.
>>>>>
>>>>> I did not investigate, but it may be due to the fact we created a
>>>>> new Git
>>>>> repository when we
>>>>> switched from svn a few days ago, so the official commit hashes are
>>>>> most
>>>>> probably different from
>>>>> yours, despite the content is the same. I would suggest you to clone
>>>>> our
>>>>> base repository again,
>>>>> so you share the same history. This way, you can update your version
>>>>> easily.
>>>>>
>>>>> best regards,
>>>>> Luc
>>>>>
>>>>>
>>>>>
>>>>>> ----
>>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>>> Author: Ole <ol...@gmail.com>
>>>>>> Date:   2014-09-29T23:56:41Z
>>>>>>
>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>
>>>>>> ----
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> If your project is set up for it, you can reply to this email and have
>>>>>> your
>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>> feature
>>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>>> please
>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>> ticket
>>>>>> with INFRA.
>>>>>> ---
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] MathIllegalStateException Description

Posted by Ole Ersoy <ol...@gmail.com>.
[...]
>>
>>  * Base class for all exceptions that signal that the process
>> throwing the exception
>>  * is in a state that does not comply with the set of states that it
>> is designed to be in.
>>
>> The only part I thought was a bit odd is the 'user's expectations' part.
>
> Fine, that may be a slight improvement. ;-)

OK - Just sent the pull request.  Come on Gilles you know this is going to be huge :).

Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] MathIllegalStateException Description

Posted by Gilles <gi...@harfang.homelinux.org>.
On Tue, 07 Oct 2014 08:02:00 -0500, Ole Ersoy wrote:
> Hi Gilles,
>
> On 10/07/2014 06:23 AM, Gilles wrote:
>> On Mon, 06 Oct 2014 14:59:04 -0500, Ole Ersoy wrote:
>>> Hi,
>>>
>>> I'm reading through some of the code in the exception package and
>>> noticed the following description for MathIllegalStateException:
>>>
>>>  * Base class for all exceptions that signal a mismatch between the
>>>  * current state and the user's expectations.
>>>
>>> I'm curious as to whether it should be:
>>>
>>>  * Base class for all exceptions that signal that the process 
>>> throwing the exception
>>>  * is in a state that does not comply with the set of states that 
>>> it is designed to be in.
>>
>> The exception may be used in circumstances where no "mathematical
>> process" is involved; it might just signal an simple inconsistency.
>> The prefix "Math" refers to the exception being a Commons Math one,
>> rather than to some math-related error.
>
> What do you think about:
>
>  * Base class for all exceptions that signal that the process
> throwing the exception
>  * is in a state that does not comply with the set of states that it
> is designed to be in.
>
> The only part I thought was a bit odd is the 'user's expectations' 
> part.

Fine, that may be a slight improvement. ;-)

Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] MathIllegalStateException Description

Posted by Ole Ersoy <ol...@gmail.com>.
Hi Gilles,

On 10/07/2014 06:23 AM, Gilles wrote:
> On Mon, 06 Oct 2014 14:59:04 -0500, Ole Ersoy wrote:
>> Hi,
>>
>> I'm reading through some of the code in the exception package and
>> noticed the following description for MathIllegalStateException:
>>
>>  * Base class for all exceptions that signal a mismatch between the
>>  * current state and the user's expectations.
>>
>> I'm curious as to whether it should be:
>>
>>  * Base class for all exceptions that signal that the process throwing the exception
>>  * is in a state that does not comply with the set of states that it is designed to be in.
>
> The exception may be used in circumstances where no "mathematical
> process" is involved; it might just signal an simple inconsistency.
> The prefix "Math" refers to the exception being a Commons Math one,
> rather than to some math-related error.

What do you think about:

  * Base class for all exceptions that signal that the process throwing the exception
  * is in a state that does not comply with the set of states that it is designed to be in.

The only part I thought was a bit odd is the 'user's expectations' part.

Cheers,
- Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Math] MathIllegalStateException Description

Posted by Gilles <gi...@harfang.homelinux.org>.
On Mon, 06 Oct 2014 14:59:04 -0500, Ole Ersoy wrote:
> Hi,
>
> I'm reading through some of the code in the exception package and
> noticed the following description for MathIllegalStateException:
>
>  * Base class for all exceptions that signal a mismatch between the
>  * current state and the user's expectations.
>
> I'm curious as to whether it should be:
>
>  * Base class for all exceptions that signal that the mathematical 
> process
>  * is in a state that does not comply with the set of states that it
> is designed to be in.

The exception may be used in circumstances where no "mathematical
process" is involved; it might just signal an simple inconsistency.
The prefix "Math" refers to the exception being a Commons Math one,
rather than to some math-related error.

Best,
Gilles

> Fairly trivial, but maybe this will give me a chance to practice
> sending another pull request :).
>
> Cheers,
> - Ole
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[Math] MathIllegalStateException Description

Posted by Ole Ersoy <ol...@gmail.com>.
Hi,

I'm reading through some of the code in the exception package and noticed the following description for MathIllegalStateException:

  * Base class for all exceptions that signal a mismatch between the
  * current state and the user's expectations.

I'm curious as to whether it should be:

  * Base class for all exceptions that signal that the mathematical process
  * is in a state that does not comply with the set of states that it is designed to be in.

Fairly trivial, but maybe this will give me a chance to practice sending another pull request :).

Cheers,
- Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
> The reason there is a difference is that the GitHub mirror was based on
> an early git mirror when our main repository was subversion. We have
> switched to Git only a few weeks ago, and the official original git
> repository has been recreated from the subversion history, not from the
> other git mirror. This means that the commits have been recreated when
> the migration was done, and the hashed are different, despite the
> content of each commit is the same. See
> <https://issues.apache.org/jira/browse/INFRA-8419>.

OK - Thanks for the update.  I'll make sure to keep it in mind next time.

Cheers,
- Ole

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 07/10/2014 20:15, Luc Maisonobe a écrit :
> Le 07/10/2014 17:34, Ole Ersoy a écrit :
>> Do I need to wait for the repositories to become synchronized before
>> doing another pull request?  It's only a tiny documentation change.
> 
> No, you can do it with the current repository, we'll refactor the patch
> as needed.

The repositories have now been synchronized, both at
http://git.apache.org/commons-math.git and at
https://github.com/apache/commons-math.

best regards,
Luc

> 
> best regards
> Luc
> 
>>
>> Thanks,
>> - Ole
>>
>> On 10/03/2014 06:46 AM, Luc Maisonobe wrote:
>>> Le 02/10/2014 17:51, Ole Ersoy a écrit :
>>>> Hello Luc, Gilles, and Benedikt,
>>>>
>>>> I'm here :).  From my limited github experience, I do think most
>>>> contributors do their communication directly through github.  I've seen
>>>> a lot of projects use issues for discussion.  I personally like this,
>>>> because it makes it easy to get up to speed on design decisions and
>>>> project history.
>>>>
>>>> Thanks for letting me know about the differences.  I'll create a new
>>>> fork for any future updates.  I'm surprised that there are differences
>>>> because I did the fork very recently and only made one small change in
>>>> vi before performing the push and pull request.  I only changed that one
>>>> file.
>>>
>>> The reason there is a difference is that the GitHub mirror was based on
>>> an early git mirror when our main repository was subversion. We have
>>> switched to Git only a few weeks ago, and the official original git
>>> repository has been recreated from the subversion history, not from the
>>> other git mirror. This means that the commits have been recreated when
>>> the migration was done, and the hashed are different, despite the
>>> content of each commit is the same. See
>>> <https://issues.apache.org/jira/browse/INFRA-8419>.
>>>
>>> best regards,
>>> Luc
>>>
>>>>
>>>> Cheers,
>>>> - Ole
>>>>
>>>> On 10/02/2014 05:03 AM, Gilles wrote:
>>>>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>>>>> Hi Luc,
>>>>>>
>>>>>> this emails are outgenerated when a PR is created at github, so I
>>>>>> wouldn't
>>>>>> expect the contributor to be subscribed to the list. It's probably
>>>>>> better
>>>>>> to comment on the PR at github.
>>>>>
>>>>> Sorry to intervene; but why is it better to bypass this list?
>>>>> Isn't it expected that a contibutor is subscribed to the project's ML,
>>>>> and not only to a forum built around one of the development tools?
>>>>>
>>>>> Best regards,
>>>>> Gilles
>>>>>
>>>>>>
>>>>>> Benedikt
>>>>>>
>>>>>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>>>>>
>>>>>>> Hi Ole,
>>>>>>>
>>>>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>>>>
>>>>>>>> GitHub user oleersoy opened a pull request:
>>>>>>>>
>>>>>>>>      https://github.com/apache/commons-math/pull/4
>>>>>>>>
>>>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> You can merge this pull request into a Git repository by running:
>>>>>>>>
>>>>>>>>      $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>>>>
>>>>>>>> Alternatively you can review and apply these changes as the patch
>>>>>>>> at:
>>>>>>>>
>>>>>>>>      https://github.com/apache/commons-math/pull/4.patch
>>>>>>>>
>>>>>>>> To close this pull request, make a commit to your master/trunk
>>>>>>>> branch
>>>>>>>> with (at least) the following in the commit message:
>>>>>>>>
>>>>>>>>      This closes #4
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I have reviewed and committed the patch.
>>>>>>>
>>>>>>> Beware that your GitHub repository seem to have a lot of differences
>>>>>>> from
>>>>>>> our
>>>>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>>>>> lot
>>>>>>> of conflicts.
>>>>>>>
>>>>>>> I did not investigate, but it may be due to the fact we created a
>>>>>>> new Git
>>>>>>> repository when we
>>>>>>> switched from svn a few days ago, so the official commit hashes are
>>>>>>> most
>>>>>>> probably different from
>>>>>>> yours, despite the content is the same. I would suggest you to clone
>>>>>>> our
>>>>>>> base repository again,
>>>>>>> so you share the same history. This way, you can update your version
>>>>>>> easily.
>>>>>>>
>>>>>>> best regards,
>>>>>>> Luc
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> ----
>>>>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>>>>> Author: Ole <ol...@gmail.com>
>>>>>>>> Date:   2014-09-29T23:56:41Z
>>>>>>>>
>>>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>>>
>>>>>>>> ----
>>>>>>>>
>>>>>>>>
>>>>>>>> ---
>>>>>>>> If your project is set up for it, you can reply to this email and
>>>>>>>> have
>>>>>>>> your
>>>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>>>> feature
>>>>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>>>>> please
>>>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>>>> ticket
>>>>>>>> with INFRA.
>>>>>>>> ---
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 07/10/2014 17:34, Ole Ersoy a écrit :
> Do I need to wait for the repositories to become synchronized before
> doing another pull request?  It's only a tiny documentation change.

No, you can do it with the current repository, we'll refactor the patch
as needed.

best regards
Luc

> 
> Thanks,
> - Ole
> 
> On 10/03/2014 06:46 AM, Luc Maisonobe wrote:
>> Le 02/10/2014 17:51, Ole Ersoy a écrit :
>>> Hello Luc, Gilles, and Benedikt,
>>>
>>> I'm here :).  From my limited github experience, I do think most
>>> contributors do their communication directly through github.  I've seen
>>> a lot of projects use issues for discussion.  I personally like this,
>>> because it makes it easy to get up to speed on design decisions and
>>> project history.
>>>
>>> Thanks for letting me know about the differences.  I'll create a new
>>> fork for any future updates.  I'm surprised that there are differences
>>> because I did the fork very recently and only made one small change in
>>> vi before performing the push and pull request.  I only changed that one
>>> file.
>>
>> The reason there is a difference is that the GitHub mirror was based on
>> an early git mirror when our main repository was subversion. We have
>> switched to Git only a few weeks ago, and the official original git
>> repository has been recreated from the subversion history, not from the
>> other git mirror. This means that the commits have been recreated when
>> the migration was done, and the hashed are different, despite the
>> content of each commit is the same. See
>> <https://issues.apache.org/jira/browse/INFRA-8419>.
>>
>> best regards,
>> Luc
>>
>>>
>>> Cheers,
>>> - Ole
>>>
>>> On 10/02/2014 05:03 AM, Gilles wrote:
>>>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>>>> Hi Luc,
>>>>>
>>>>> this emails are outgenerated when a PR is created at github, so I
>>>>> wouldn't
>>>>> expect the contributor to be subscribed to the list. It's probably
>>>>> better
>>>>> to comment on the PR at github.
>>>>
>>>> Sorry to intervene; but why is it better to bypass this list?
>>>> Isn't it expected that a contibutor is subscribed to the project's ML,
>>>> and not only to a forum built around one of the development tools?
>>>>
>>>> Best regards,
>>>> Gilles
>>>>
>>>>>
>>>>> Benedikt
>>>>>
>>>>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>>>>
>>>>>> Hi Ole,
>>>>>>
>>>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>>>
>>>>>>> GitHub user oleersoy opened a pull request:
>>>>>>>
>>>>>>>      https://github.com/apache/commons-math/pull/4
>>>>>>>
>>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> You can merge this pull request into a Git repository by running:
>>>>>>>
>>>>>>>      $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>>>
>>>>>>> Alternatively you can review and apply these changes as the patch
>>>>>>> at:
>>>>>>>
>>>>>>>      https://github.com/apache/commons-math/pull/4.patch
>>>>>>>
>>>>>>> To close this pull request, make a commit to your master/trunk
>>>>>>> branch
>>>>>>> with (at least) the following in the commit message:
>>>>>>>
>>>>>>>      This closes #4
>>>>>>>
>>>>>>
>>>>>>
>>>>>> I have reviewed and committed the patch.
>>>>>>
>>>>>> Beware that your GitHub repository seem to have a lot of differences
>>>>>> from
>>>>>> our
>>>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>>>> lot
>>>>>> of conflicts.
>>>>>>
>>>>>> I did not investigate, but it may be due to the fact we created a
>>>>>> new Git
>>>>>> repository when we
>>>>>> switched from svn a few days ago, so the official commit hashes are
>>>>>> most
>>>>>> probably different from
>>>>>> yours, despite the content is the same. I would suggest you to clone
>>>>>> our
>>>>>> base repository again,
>>>>>> so you share the same history. This way, you can update your version
>>>>>> easily.
>>>>>>
>>>>>> best regards,
>>>>>> Luc
>>>>>>
>>>>>>
>>>>>>
>>>>>>> ----
>>>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>>>> Author: Ole <ol...@gmail.com>
>>>>>>> Date:   2014-09-29T23:56:41Z
>>>>>>>
>>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>>
>>>>>>> ----
>>>>>>>
>>>>>>>
>>>>>>> ---
>>>>>>> If your project is set up for it, you can reply to this email and
>>>>>>> have
>>>>>>> your
>>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>>> feature
>>>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>>>> please
>>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>>> ticket
>>>>>>> with INFRA.
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
Do I need to wait for the repositories to become synchronized before doing another pull request?  It's only a tiny documentation change.

Thanks,
- Ole

On 10/03/2014 06:46 AM, Luc Maisonobe wrote:
> Le 02/10/2014 17:51, Ole Ersoy a écrit :
>> Hello Luc, Gilles, and Benedikt,
>>
>> I'm here :).  From my limited github experience, I do think most
>> contributors do their communication directly through github.  I've seen
>> a lot of projects use issues for discussion.  I personally like this,
>> because it makes it easy to get up to speed on design decisions and
>> project history.
>>
>> Thanks for letting me know about the differences.  I'll create a new
>> fork for any future updates.  I'm surprised that there are differences
>> because I did the fork very recently and only made one small change in
>> vi before performing the push and pull request.  I only changed that one
>> file.
>
> The reason there is a difference is that the GitHub mirror was based on
> an early git mirror when our main repository was subversion. We have
> switched to Git only a few weeks ago, and the official original git
> repository has been recreated from the subversion history, not from the
> other git mirror. This means that the commits have been recreated when
> the migration was done, and the hashed are different, despite the
> content of each commit is the same. See
> <https://issues.apache.org/jira/browse/INFRA-8419>.
>
> best regards,
> Luc
>
>>
>> Cheers,
>> - Ole
>>
>> On 10/02/2014 05:03 AM, Gilles wrote:
>>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>>> Hi Luc,
>>>>
>>>> this emails are outgenerated when a PR is created at github, so I
>>>> wouldn't
>>>> expect the contributor to be subscribed to the list. It's probably
>>>> better
>>>> to comment on the PR at github.
>>>
>>> Sorry to intervene; but why is it better to bypass this list?
>>> Isn't it expected that a contibutor is subscribed to the project's ML,
>>> and not only to a forum built around one of the development tools?
>>>
>>> Best regards,
>>> Gilles
>>>
>>>>
>>>> Benedikt
>>>>
>>>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>>>
>>>>> Hi Ole,
>>>>>
>>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>>
>>>>>> GitHub user oleersoy opened a pull request:
>>>>>>
>>>>>>      https://github.com/apache/commons-math/pull/4
>>>>>>
>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>
>>>>>>
>>>>>>
>>>>>> You can merge this pull request into a Git repository by running:
>>>>>>
>>>>>>      $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>>
>>>>>> Alternatively you can review and apply these changes as the patch at:
>>>>>>
>>>>>>      https://github.com/apache/commons-math/pull/4.patch
>>>>>>
>>>>>> To close this pull request, make a commit to your master/trunk branch
>>>>>> with (at least) the following in the commit message:
>>>>>>
>>>>>>      This closes #4
>>>>>>
>>>>>
>>>>>
>>>>> I have reviewed and committed the patch.
>>>>>
>>>>> Beware that your GitHub repository seem to have a lot of differences
>>>>> from
>>>>> our
>>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>>> lot
>>>>> of conflicts.
>>>>>
>>>>> I did not investigate, but it may be due to the fact we created a
>>>>> new Git
>>>>> repository when we
>>>>> switched from svn a few days ago, so the official commit hashes are
>>>>> most
>>>>> probably different from
>>>>> yours, despite the content is the same. I would suggest you to clone
>>>>> our
>>>>> base repository again,
>>>>> so you share the same history. This way, you can update your version
>>>>> easily.
>>>>>
>>>>> best regards,
>>>>> Luc
>>>>>
>>>>>
>>>>>
>>>>>> ----
>>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>>> Author: Ole <ol...@gmail.com>
>>>>>> Date:   2014-09-29T23:56:41Z
>>>>>>
>>>>>>      Updated the example documentation for the GaussianCurveFitte
>>>>>>
>>>>>> ----
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> If your project is set up for it, you can reply to this email and have
>>>>>> your
>>>>>> reply appear on GitHub as well. If your project does not have this
>>>>>> feature
>>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>>> please
>>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>> ticket
>>>>>> with INFRA.
>>>>>> ---
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 02/10/2014 17:51, Ole Ersoy a écrit :
> Hello Luc, Gilles, and Benedikt,
> 
> I'm here :).  From my limited github experience, I do think most
> contributors do their communication directly through github.  I've seen
> a lot of projects use issues for discussion.  I personally like this,
> because it makes it easy to get up to speed on design decisions and
> project history.
> 
> Thanks for letting me know about the differences.  I'll create a new
> fork for any future updates.  I'm surprised that there are differences
> because I did the fork very recently and only made one small change in
> vi before performing the push and pull request.  I only changed that one
> file.

The reason there is a difference is that the GitHub mirror was based on
an early git mirror when our main repository was subversion. We have
switched to Git only a few weeks ago, and the official original git
repository has been recreated from the subversion history, not from the
other git mirror. This means that the commits have been recreated when
the migration was done, and the hashed are different, despite the
content of each commit is the same. See
<https://issues.apache.org/jira/browse/INFRA-8419>.

best regards,
Luc

> 
> Cheers,
> - Ole
> 
> On 10/02/2014 05:03 AM, Gilles wrote:
>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>> Hi Luc,
>>>
>>> this emails are outgenerated when a PR is created at github, so I
>>> wouldn't
>>> expect the contributor to be subscribed to the list. It's probably
>>> better
>>> to comment on the PR at github.
>>
>> Sorry to intervene; but why is it better to bypass this list?
>> Isn't it expected that a contibutor is subscribed to the project's ML,
>> and not only to a forum built around one of the development tools?
>>
>> Best regards,
>> Gilles
>>
>>>
>>> Benedikt
>>>
>>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>>
>>>> Hi Ole,
>>>>
>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>
>>>>> GitHub user oleersoy opened a pull request:
>>>>>
>>>>>     https://github.com/apache/commons-math/pull/4
>>>>>
>>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>>
>>>>>
>>>>>
>>>>> You can merge this pull request into a Git repository by running:
>>>>>
>>>>>     $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>
>>>>> Alternatively you can review and apply these changes as the patch at:
>>>>>
>>>>>     https://github.com/apache/commons-math/pull/4.patch
>>>>>
>>>>> To close this pull request, make a commit to your master/trunk branch
>>>>> with (at least) the following in the commit message:
>>>>>
>>>>>     This closes #4
>>>>>
>>>>
>>>>
>>>> I have reviewed and committed the patch.
>>>>
>>>> Beware that your GitHub repository seem to have a lot of differences
>>>> from
>>>> our
>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>> lot
>>>> of conflicts.
>>>>
>>>> I did not investigate, but it may be due to the fact we created a
>>>> new Git
>>>> repository when we
>>>> switched from svn a few days ago, so the official commit hashes are
>>>> most
>>>> probably different from
>>>> yours, despite the content is the same. I would suggest you to clone
>>>> our
>>>> base repository again,
>>>> so you share the same history. This way, you can update your version
>>>> easily.
>>>>
>>>> best regards,
>>>> Luc
>>>>
>>>>
>>>>
>>>>> ----
>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>> Author: Ole <ol...@gmail.com>
>>>>> Date:   2014-09-29T23:56:41Z
>>>>>
>>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>>
>>>>> ----
>>>>>
>>>>>
>>>>> ---
>>>>> If your project is set up for it, you can reply to this email and have
>>>>> your
>>>>> reply appear on GitHub as well. If your project does not have this
>>>>> feature
>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>> please
>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>> ticket
>>>>> with INFRA.
>>>>> ---
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Ole Ersoy <ol...@gmail.com>.
Hello Luc, Gilles, and Benedikt,

I'm here :).  From my limited github experience, I do think most contributors do their communication directly through github.  I've seen a lot of projects use issues for discussion.  I personally like this, because it makes it easy to get up to speed on design decisions and project history.

Thanks for letting me know about the differences.  I'll create a new fork for any future updates.  I'm surprised that there are differences because I did the fork very recently and only made one small change in vi before performing the push and pull request.  I only changed that one file.

Cheers,
- Ole

On 10/02/2014 05:03 AM, Gilles wrote:
> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>> Hi Luc,
>>
>> this emails are outgenerated when a PR is created at github, so I wouldn't
>> expect the contributor to be subscribed to the list. It's probably better
>> to comment on the PR at github.
>
> Sorry to intervene; but why is it better to bypass this list?
> Isn't it expected that a contibutor is subscribed to the project's ML,
> and not only to a forum built around one of the development tools?
>
> Best regards,
> Gilles
>
>>
>> Benedikt
>>
>> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>>
>>> Hi Ole,
>>>
>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>
>>>> GitHub user oleersoy opened a pull request:
>>>>
>>>>     https://github.com/apache/commons-math/pull/4
>>>>
>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>
>>>>
>>>>
>>>> You can merge this pull request into a Git repository by running:
>>>>
>>>>     $ git pull https://github.com/oleersoy/commons-math trunk
>>>>
>>>> Alternatively you can review and apply these changes as the patch at:
>>>>
>>>>     https://github.com/apache/commons-math/pull/4.patch
>>>>
>>>> To close this pull request, make a commit to your master/trunk branch
>>>> with (at least) the following in the commit message:
>>>>
>>>>     This closes #4
>>>>
>>>
>>>
>>> I have reviewed and committed the patch.
>>>
>>> Beware that your GitHub repository seem to have a lot of differences from
>>> our
>>> Apache repository. When I atempted a simple "git pull", there were a lot
>>> of conflicts.
>>>
>>> I did not investigate, but it may be due to the fact we created a new Git
>>> repository when we
>>> switched from svn a few days ago, so the official commit hashes are most
>>> probably different from
>>> yours, despite the content is the same. I would suggest you to clone our
>>> base repository again,
>>> so you share the same history. This way, you can update your version
>>> easily.
>>>
>>> best regards,
>>> Luc
>>>
>>>
>>>
>>>> ----
>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>> Author: Ole <ol...@gmail.com>
>>>> Date:   2014-09-29T23:56:41Z
>>>>
>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>
>>>> ----
>>>>
>>>>
>>>> ---
>>>> If your project is set up for it, you can reply to this email and have
>>>> your
>>>> reply appear on GitHub as well. If your project does not have this feature
>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>> please
>>>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>>>> with INFRA.
>>>> ---
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Gilles <gi...@harfang.homelinux.org>.
On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
> Hi Luc,
>
> this emails are outgenerated when a PR is created at github, so I 
> wouldn't
> expect the contributor to be subscribed to the list. It's probably 
> better
> to comment on the PR at github.

Sorry to intervene; but why is it better to bypass this list?
Isn't it expected that a contibutor is subscribed to the project's ML,
and not only to a forum built around one of the development tools?

Best regards,
Gilles

>
> Benedikt
>
> 2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:
>
>> Hi Ole,
>>
>> Le 2014-09-30 02:09, oleersoy a écrit :
>>
>>> GitHub user oleersoy opened a pull request:
>>>
>>>     https://github.com/apache/commons-math/pull/4
>>>
>>>     Updated the example documentation for the GaussianCurveFitte
>>>
>>>
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>>     $ git pull https://github.com/oleersoy/commons-math trunk
>>>
>>> Alternatively you can review and apply these changes as the patch 
>>> at:
>>>
>>>     https://github.com/apache/commons-math/pull/4.patch
>>>
>>> To close this pull request, make a commit to your master/trunk 
>>> branch
>>> with (at least) the following in the commit message:
>>>
>>>     This closes #4
>>>
>>
>>
>> I have reviewed and committed the patch.
>>
>> Beware that your GitHub repository seem to have a lot of differences 
>> from
>> our
>> Apache repository. When I atempted a simple "git pull", there were a 
>> lot
>> of conflicts.
>>
>> I did not investigate, but it may be due to the fact we created a 
>> new Git
>> repository when we
>> switched from svn a few days ago, so the official commit hashes are 
>> most
>> probably different from
>> yours, despite the content is the same. I would suggest you to clone 
>> our
>> base repository again,
>> so you share the same history. This way, you can update your version
>> easily.
>>
>> best regards,
>> Luc
>>
>>
>>
>>> ----
>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>> Author: Ole <ol...@gmail.com>
>>> Date:   2014-09-29T23:56:41Z
>>>
>>>     Updated the example documentation for the GaussianCurveFitte
>>>
>>> ----
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and 
>>> have
>>> your
>>> reply appear on GitHub as well. If your project does not have this 
>>> feature
>>> enabled and wishes so, or if the feature is enabled but not 
>>> working,
>>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA 
>>> ticket
>>> with INFRA.
>>> ---
>>>
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by Benedikt Ritter <br...@apache.org>.
Hi Luc,

this emails are outgenerated when a PR is created at github, so I wouldn't
expect the contributor to be subscribed to the list. It's probably better
to comment on the PR at github.

Benedikt

2014-09-30 9:55 GMT+02:00 luc <lu...@spaceroots.org>:

> Hi Ole,
>
> Le 2014-09-30 02:09, oleersoy a écrit :
>
>> GitHub user oleersoy opened a pull request:
>>
>>     https://github.com/apache/commons-math/pull/4
>>
>>     Updated the example documentation for the GaussianCurveFitte
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>>     $ git pull https://github.com/oleersoy/commons-math trunk
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>>     https://github.com/apache/commons-math/pull/4.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>>     This closes #4
>>
>
>
> I have reviewed and committed the patch.
>
> Beware that your GitHub repository seem to have a lot of differences from
> our
> Apache repository. When I atempted a simple "git pull", there were a lot
> of conflicts.
>
> I did not investigate, but it may be due to the fact we created a new Git
> repository when we
> switched from svn a few days ago, so the official commit hashes are most
> probably different from
> yours, despite the content is the same. I would suggest you to clone our
> base repository again,
> so you share the same history. This way, you can update your version
> easily.
>
> best regards,
> Luc
>
>
>
>> ----
>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>> Author: Ole <ol...@gmail.com>
>> Date:   2014-09-29T23:56:41Z
>>
>>     Updated the example documentation for the GaussianCurveFitte
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

Posted by luc <lu...@spaceroots.org>.
Hi Ole,

Le 2014-09-30 02:09, oleersoy a écrit :
> GitHub user oleersoy opened a pull request:
> 
>     https://github.com/apache/commons-math/pull/4
> 
>     Updated the example documentation for the GaussianCurveFitte
> 
> 
> 
> You can merge this pull request into a Git repository by running:
> 
>     $ git pull https://github.com/oleersoy/commons-math trunk
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>     https://github.com/apache/commons-math/pull/4.patch
> 
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> 
>     This closes #4


I have reviewed and committed the patch.

Beware that your GitHub repository seem to have a lot of differences 
from our
Apache repository. When I atempted a simple "git pull", there were a lot 
of conflicts.

I did not investigate, but it may be due to the fact we created a new 
Git repository when we
switched from svn a few days ago, so the official commit hashes are most 
probably different from
yours, despite the content is the same. I would suggest you to clone our 
base repository again,
so you share the same history. This way, you can update your version 
easily.

best regards,
Luc

> 
> ----
> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
> Author: Ole <ol...@gmail.com>
> Date:   2014-09-29T23:56:41Z
> 
>     Updated the example documentation for the GaussianCurveFitte
> 
> ----
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have 
> your
> reply appear on GitHub as well. If your project does not have this 
> feature
> enabled and wishes so, or if the feature is enabled but not working, 
> please
> contact infrastructure at infrastructure@apache.org or file a JIRA 
> ticket
> with INFRA.
> ---
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org