You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 08:43:00 UTC
[GitHub] [spark] gengliangwang commented on a change in pull request #27608:
[SPARK-30863][SQL] Distinguish Cast and AnsiCast in toString
gengliangwang commented on a change in pull request #27608: [SPARK-30863][SQL] Distinguish Cast and AnsiCast in toString
URL: https://github.com/apache/spark/pull/27608#discussion_r380526003
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -251,7 +251,10 @@ abstract class CastBase extends UnaryExpression with TimeZoneAwareExpression wit
def dataType: DataType
- override def toString: String = s"cast($child as ${dataType.simpleString})"
+ override def toString: String = {
+ val ansi = if (ansiEnabled) "ansi_" else ""
Review comment:
I see. It is the first expression the overrides `toString` with 2 words in IDE...haha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org