You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:09:02 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #6157: Fix wrong label entity.type

davidjumani opened a new pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157


   ### Description
   
   Fixes the wrong label in the annotations search view
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   ### Screenshots (if appropriate):
   
   ![Screenshot from 2022-03-23 12-36-54](https://user-images.githubusercontent.com/8244774/159642938-7f90ed97-86a5-4c32-bd3c-97b232e9ddee.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani removed a comment on pull request #6157: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#issuecomment-1075997763


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #6157: ui: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#discussion_r834051449



##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -53,8 +53,7 @@
                   v-for="(field, index) in fields"
                   :key="index"
                   :label="field.name==='keyword' ?
-                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) :
-                    (field.name==='entitytype' ? $t('label.entity.type') : $t('label.' + field.name))">
+                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) : $t('label.' + field.name)">

Review comment:
       ```
   condition-1 ? 
       (condition-2 ? label1 : label2) : label3
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6157: ui: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#discussion_r834018014



##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -53,8 +53,7 @@
                   v-for="(field, index) in fields"
                   :key="index"
                   :label="field.name==='keyword' ?
-                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) :
-                    (field.name==='entitytype' ? $t('label.entity.type') : $t('label.' + field.name))">
+                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) : $t('label.' + field.name)">

Review comment:
       @davidjumani is your syntax correct: `condition ? label1 : label2 : label 3` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6157: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#issuecomment-1075997763


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6157: ui: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#discussion_r834065649



##########
File path: ui/src/components/view/SearchView.vue
##########
@@ -53,8 +53,7 @@
                   v-for="(field, index) in fields"
                   :key="index"
                   :label="field.name==='keyword' ?
-                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) :
-                    (field.name==='entitytype' ? $t('label.entity.type') : $t('label.' + field.name))">
+                    ('listAnnotations' in $store.getters.apis ? $t('label.annotation') : $t('label.name')) : $t('label.' + field.name)">

Review comment:
       /me rubs my eyes, missed reading the `keyword' ?`... LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #6157: ui: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6157: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#issuecomment-1076001218


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6157: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#issuecomment-1076004763


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6157 (SL-JID-1288)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6157: Fix wrong label entity.type

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6157:
URL: https://github.com/apache/cloudstack/pull/6157#issuecomment-1076001517


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org