You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <Ma...@mch.sni.de> on 1998/01/17 13:53:42 UTC

[PATCH] Improve implementation of -c/-Cdirective reading (take 2)

On Fri, Jan 16, 1998 at 11:24:23AM +1300, Doug MacEachern wrote:
> +1 on concept.   the patch makes one .rej files which I applied by
> hand, but my sore eyes can't see what's wrong:
> util.c: In function `pcfg_openfile':
> util.c:715: parse error before `*'
> util.c:726: `param' undeclared (first use this function)

Could have been a gcc bug(I'm using a different compiler here). Anyway
I undid the prototype beautification and #ifdef'ed the fstat code.

Furthermore, I  added a missing error printf and sent the whole thing
thru indent, so here's take 2.

> isokay, the #ifdef MOD_PERL isn't needed anymore.
Removed that too.

    Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request

Re: [PATCH] Improve implementation of -c/-Cdirective reading (take 2)

Posted by Doug MacEachern <do...@telebusiness.co.nz>.
Martin Kraemer wrote:

> On Fri, Jan 16, 1998 at 11:24:23AM +1300, Doug MacEachern wrote:
> > +1 on concept.   the patch makes one .rej files which I applied by
> > hand, but my sore eyes can't see what's wrong:
> > util.c: In function `pcfg_openfile':
> > util.c:715: parse error before `*'
> > util.c:726: `param' undeclared (first use this function)
>
> Could have been a gcc bug(I'm using a different compiler here). Anyway
> I undid the prototype beautification and #ifdef'ed the fstat code.
>
> Furthermore, I  added a missing error printf and sent the whole thing
> thru indent, so here's take 2.

Sweetness.   Works great, +1

-Doug