You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/07/07 09:09:27 UTC

[GitHub] [avro] martin-g commented on pull request #1282: AVRO-3169: Fix 'cargo build' by removing trailing comma

martin-g commented on pull request #1282:
URL: https://github.com/apache/avro/pull/1282#issuecomment-875432506


   @iemejia `cargo clippy --all-targets --all-features -- -Dclippy::all` (part of `lang/rust/.pre-commit-config.yaml`) also complains about this comma:
   
   ```
   error: no rules expected the token `,`
      --> src/schema.rs:163:37
       |
   163 |                 | SchemaKind::String,
       |                                     ^ no rules expected this token in macro call
   
       Checking criterion v0.3.4
   error: aborting due to previous error
   
   error: could not compile `avro-rs`.
   ```
   
   Do you see a problem in removing this comma ?
   This way even older versions of rustc could be used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org