You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/24 08:45:25 UTC

[GitHub] [spark] AngersZhuuuu commented on pull request #28107: [SPARK-31334][SQL] Don't ResolveReference/ResolveMissingReference when Filter condition with aggregate expression

AngersZhuuuu commented on pull request #28107:
URL: https://github.com/apache/spark/pull/28107#issuecomment-618886329


   > This PR exposes a more serious problem, that we rely on rules order to resolve HAVING. We can easily get correctness issues because of it.
   > 
   > #28294 proposes a new solution to fix this problem completely, can you take a look?
   
   The pr you mentioned is similar like I have said in https://github.com/apache/spark/pull/28107#issuecomment-609029296
   
   It's better to to like this, I will notice that pr and check if that pr will solve this pr's problem, if not, I will change based on his pr.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org