You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/05/24 23:33:32 UTC
[PR] test(frontend): extend joint-ui.service coverage and drop dead test block [texera]
Yicong-Huang opened a new pull request, #5196:
URL: https://github.com/apache/texera/pull/5196
### What changes were proposed in this PR?
Closes #5195. `joint-ui.service.spec.ts` opened with ~60 commented test lines plus an `it.todo("add unit tests for JointUIService")` placeholder. Five of the seven methods those commented tests called were removed from `JointUIService` long ago (`getJointOperatorStatusTooltipElement`, `changeOperatorStates`, `changeOperatorTooltipInfo`, `showToolTip`, `hideTooltip`); the commented block is unrevivable dead code.
Delete that block and the now-redundant placeholder. Add direct coverage for the public surface the spec was leaving behind — static helpers (`getOperatorFillColor`, `getOperatorCacheDisplayText`, `getOperatorCacheIcon`, `getOperatorViewResultIcon`, `getJointLinkCell`, `getJointUserPointerName`, `getJointUserPointerCell`), joint-paper-bound methods (`changeOperatorColor`, `changeOperatorState`, `foldOperatorDetails`/`unfoldOperatorDetails`, `showAgentActionLabel`/`hideAgentActionLabel`, `getCommentElement`), and `getJointOperatorElement`'s unknown-operator-type throw branch.
### Any related issues, documentation, discussions?
Closes #5195. Same shape as #5194.
### How was this PR tested?
`yarn ng test --watch=false --include=…` runs 42 tests, all green. `yarn lint` and `yarn format:ci` both clean. v8 line coverage of `joint-ui.service.ts` rises from 34 % (75/220) to 70 % (155/220).
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover joint-ui.service surface and remove dead code [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5196:
URL: https://github.com/apache/texera/pull/5196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend joint-ui.service coverage and drop dead test block [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5196:
URL: https://github.com/apache/texera/pull/5196#issuecomment-4530540548
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5196?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 45.53%. Comparing base ([`a25c543`](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`77cc81d`](https://app.codecov.io/gh/apache/texera/commit/77cc81dcb14a9bbae2a5397ce981021e2068a574?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5196 +/- ##
============================================
+ Coverage 45.39% 45.53% +0.13%
Complexity 2218 2218
============================================
Files 1042 1042
Lines 39989 39989
Branches 4260 4260
============================================
+ Hits 18152 18207 +55
+ Misses 20720 20670 -50
+ Partials 1117 1112 -5
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.75% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.13% <ø> (+0.34%)` | :arrow_up: | |
| [python](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.50% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (ø)` | | Carriedforward from [a25c543](https://app.codecov.io/gh/apache/texera/commit/a25c54348d95dbc149ca3f48db0c061623c88b8c?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5196?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org