You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Karishma Gulati <gu...@yahoo.com> on 2014/11/03 14:05:52 UTC
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 1:05 p.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java b9acc3b
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java d240e76
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java 86d4d47
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63364
-----------------------------------------------------------
we can't add that jar due to https://issues.apache.org/jira/browse/FALCON-900. As a variant we can use one which already present, for example merlin/src/test/resources/oozie/lib/oozie-examples-3.1.5.jar.
- Paul Isaychuk
On Nov. 3, 2014, 1:05 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 1:05 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java b9acc3b
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java d240e76
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java 86d4d47
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 7:23 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review71504
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Feb. 4, 2015, 2:01 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 10:01 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
> On Jan. 30, 2015, 7:18 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java, line 213
> > <https://reviews.apache.org/r/25336/diff/8/?file=807724#file807724line213>
> >
> > This will not work on Windows and also, the test to be launched from the first cluster. From what I see in the test, ssh action is not testing any falcon feature. Other action check if all the parameters are passed to the workflow.
> >
> > In general, it is better to stay away from ssh - unless absolutely necessary.
Alright, will remove ssh action from the test for now. Will add a more meaningful test for ssh later in case such a need arises. Thanks.
- Karishma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review70402
-----------------------------------------------------------
On Jan. 6, 2015, 11:49 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 11:49 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review70402
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
<https://reviews.apache.org/r/25336/#comment115576>
This will not work on Windows and also, the test to be launched from the first cluster. From what I see in the test, ssh action is not testing any falcon feature. Other action check if all the parameters are passed to the workflow.
In general, it is better to stay away from ssh - unless absolutely necessary.
- Raghav Gautam
On Jan. 6, 2015, 3:49 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 3:49 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 11:49 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review66815
-----------------------------------------------------------
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml
<https://reviews.apache.org/r/25336/#comment110452>
Why this was changed back to 'ivory' in 7th revision? It will be replaced to MerlinConstants.STAGING(WORKING)LOCATION anyway. We should avoid 'ivory' after FALCON-930
- Ruslan Ostafiychuk
On Dec. 30, 2014, 11:16 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 11:16 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 11:16 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 9:44 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
> On Dec. 3, 2014, 12:49 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java, line 214
> > <https://reviews.apache.org/r/25336/diff/5/?file=781536#file781536line214>
> >
> > we are trying to aviod using runRemoteScriptAsSudo()
> > this code will not work on Windows
> >
> > Looks like this can be done manually with single 'ssh-copy-id' command
Didn't want the test to expect anything that has to be done manually. Can you suggest something for windows?
- Karishma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63666
-----------------------------------------------------------
On Dec. 30, 2014, 9:44 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 9:44 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 6e25a60
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63666
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
<https://reviews.apache.org/r/25336/#comment105946>
level 16 expected by checkstyle, not 12
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java
<https://reviews.apache.org/r/25336/#comment105945>
we are trying to aviod using runRemoteScriptAsSudo()
this code will not work on Windows
Looks like this can be done manually with single 'ssh-copy-id' command
- Ruslan Ostafiychuk
On Dec. 3, 2014, 11:06 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 11:06 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63664
-----------------------------------------------------------
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml
<https://reviews.apache.org/r/25336/#comment105940>
I'm sorry, I have missed it in previous review, due to https://issues.apache.org/jira/browse/FALCON-909 we are removing all references to inmobi as well as contributors names (e.g samarth in paths) and other deprecated references, ivory etc.
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml
<https://reviews.apache.org/r/25336/#comment105941>
samarth, ivory should be removed also
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml
<https://reviews.apache.org/r/25336/#comment105942>
the same
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml
<https://reviews.apache.org/r/25336/#comment105943>
the same
- Paul Isaychuk
On Dec. 3, 2014, 11:06 a.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 11:06 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 11:06 a.m.)
Review request for Falcon.
Repository: falcon-git
Description
-------
A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java 7ead733
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java 82c8919
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java ed29d07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
Diff: https://reviews.apache.org/r/25336/diff/
Testing
-------
Thanks,
Karishma Gulati
Re: Review Request 25336: [Falcon-671] Add a test in
falcon-regression where
one oozie workflow has various actions like mr, hive, pig
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25336/#review63366
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java
<https://reviews.apache.org/r/25336/#comment105582>
here is checkstyle issue. Line 61 is longer then 120 symbols.
- Paul Isaychuk
On Nov. 3, 2014, 1:05 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25336/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 1:05 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> A test needs to be added where one worflow has various possible actions like mr, hive, pig. So far, we just specify the engine type as hive or pig for such specific tests.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java b9acc3b
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java d240e76
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java d878ecb
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java 86d4d47
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/lib/oozie-examples-3.1.5.jar PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql PRE-CREATION
> falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25336/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>