You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2009/09/02 02:42:32 UTC
[jira] Created: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
-----------------------------------------------------------------------------------------------
Key: HADOOP-6229
URL: https://issues.apache.org/jira/browse/HADOOP-6229
Project: Hadoop Common
Issue Type: Bug
Components: fs
Reporter: Boris Shkolnik
This task is sub task of HDFS-303
{quote}
"1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
An IOException seems good here. "
{quote}
Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Status: Open (was: Patch Available)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750750#action_12750750 ]
Boris Shkolnik commented on HADOOP-6229:
----------------------------------------
Ran hadoop-common test, hadoop-hdfs and hadoop-mapreduce with new hadoop-common jar
Also created a new hadoop-mapreduce jars (with the new core jars) and ran hadoop-hdfs test with them.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Attachment: HADOOP-6229.patch
Took Nikolas' suggestion. Created new class FileAlreadyExestsException.
Turns out mapred already has such class.
After this patch is committed I will remove mapred's one and make it use this one (from common).
Also I will need to change HDFS to use this new exception instead of FileNotFound.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Status: Patch Available (was: Open)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750756#action_12750756 ]
Konstantin Boudnik commented on HADOOP-6229:
--------------------------------------------
I believe the original code isn't defensive enough and there's a possibility for NPE to be thrown if {{Path f}} happens to be {{null}}. I'd add an extra check for this as the very first line of the method.
Looks good otherwise.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Status: Patch Available (was: Open)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Attachment: HADOOP-6229-2.patch
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Status: Open (was: Patch Available)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750777#action_12750777 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6229:
------------------------------------------------
Forgot to add FileAlreadyExistsException.java?
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Attachment: HADOOP-6229-2.patch
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752134#action_12752134 ]
Hudson commented on HADOOP-6229:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #16 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/16/])
. Attempt to make a directory under an existing file on LocalFileSystem should throw an Exception. Contributed by Boris Shkolnik.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-6229:
------------------------------------
Release Note: (was: New behavior:
if mkdirs(p) argument's parent is an existing file the method will throw FileAlreadyExistsException.
if mkdirs(p) argument is null it will throw IllegalArgumentException)
Editorial pass over all release notes prior to publication of 0.21. Bug.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751222#action_12751222 ]
Tom White commented on HADOOP-6229:
-----------------------------------
+1
This will be tested by the test being introduced in HDFS-303, right?
Minor nit: we tend not to add serialVersionUID fields. (Any warnings in IDEs should be turned off.)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HADOOP-6229:
--------------------------------------
Assignee: Boris Shkolnik
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750207#action_12750207 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6229:
------------------------------------------------
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
Does throwing a FileAlreadyExistsException (a new class) make more sense in this case?
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751237#action_12751237 ]
Hadoop QA commented on HADOOP-6229:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12418563/HADOOP-6229-2.patch
against trunk revision 810756.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 146 javac compiler warnings (more than the trunk's current 145 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/16/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/16/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/16/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/16/console
This message is automatically generated.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750218#action_12750218 ]
Konstantin Boudnik commented on HADOOP-6229:
--------------------------------------------
I second Nicholas' suggestion.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752442#action_12752442 ]
Hudson commented on HADOOP-6229:
--------------------------------
Integrated in Hadoop-Common-trunk #89 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/89/])
. Attempt to make a directory under an existing file on LocalFileSystem should throw an Exception. Contributed by Boris Shkolnik.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751185#action_12751185 ]
Hadoop QA commented on HADOOP-6229:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12418544/HADOOP-6229-1.patch
against trunk revision 810756.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/14/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/14/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/14/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/14/console
This message is automatically generated.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750758#action_12750758 ]
Hadoop QA commented on HADOOP-6229:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12418453/HADOOP-6229.patch
against trunk revision 810714.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/11/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/11/console
This message is automatically generated.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751228#action_12751228 ]
Boris Shkolnik commented on HADOOP-6229:
----------------------------------------
removed serialVersionUID.
Added some unit test in any case for hadoop-common.
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Attachment: HADOOP-6229-1.patch
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Status: Patch Available (was: Open)
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6229:
-----------------------------------
Release Note:
New behavior:
if mkdirs(p) argument's parent is an existing file the method will throw FileAlreadyExistsException.
if mkdirs(p) argument is null it will throw IllegalArgumentException
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6229:
------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Boris!
Could you update the release note with the new behaviour please?
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6229) Atempt to make a directory under an
existing file on LocalFileSystem should throw an Exception.
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751256#action_12751256 ]
Konstantin Boudnik commented on HADOOP-6229:
--------------------------------------------
+1 patch looks good
> Atempt to make a directory under an existing file on LocalFileSystem should throw an Exception.
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-6229
> URL: https://issues.apache.org/jira/browse/HADOOP-6229
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6229-1.patch, HADOOP-6229-2.patch, HADOOP-6229-2.patch, HADOOP-6229.patch
>
>
> This task is sub task of HDFS-303
> {quote}
> "1. When trying to make a directory under an existing file, HDFS throws an IOException while LocalFileSystem doesn't.
> An IOException seems good here. "
> {quote}
> Actually HDFS throws FileNotFoundException in this case (in FSDirectory.mkdirs() ). So I guess we should do the same.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.