You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/10/22 19:41:37 UTC

[GitHub] cvanem commented on issue #325: iPhone X support

cvanem commented on issue #325: iPhone X support
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/325#issuecomment-431894360
 
 
   I am also having this issue on an iPhone XS.  The status bar looks fine in the Cordova webview (using cordova- plugin-statusbar).  After the inappbrowser is opened the status bar appears incorrect.  I would also expect the status bar area to be hidden when the phone is in landscape mode.  
   
   Here is how it looks in portrait mode:
   
   ![potrait](https://user-images.githubusercontent.com/24579103/47305410-9bed1380-d5e6-11e8-8631-eff8798b1b70.png)
   
   This is landscape.  The status bar text is gone, but the area is still offset.  This area should not be displayed when in landscape mode.
   
   ![landscape](https://user-images.githubusercontent.com/24579103/47305409-9bed1380-d5e6-11e8-9541-f5c7410f4f13.png)
   
   This is how I would expect it to look and how it looks in the Cordova webview: 
   ![expected](https://user-images.githubusercontent.com/24579103/47305436-ac04f300-d5e6-11e8-9aad-03588fb8cc30.png)
   
   I have had some success by manually setting the STATUSBAR_HEIGHT to 0 in the CDVInAppBrowser.m file, but this then requires the padding to be implemented in user space and does not allow altercations to the text color.
   
   It would be nice if the inappbrowser inherited the settings from the Cordova WebView using cordova-plugin-statusbar.  
   
   Has anyone found a solution other than modifying the source code?
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org