[GitHub] [arrow] kou commented on a diff in pull request #12719: ARROW-16032: [C++] Migrate FlightClient API to Result<>

[GitBox <gi...@apache.org>]

kou commented on code in PR #12719:
URL: https://github.com/apache/arrow/pull/12719#discussion_r844553982


##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -251,12 +251,12 @@ gaflight_client_new(GAFlightLocation *location,
   arrow::Status status;
   if (options) {
     const auto flight_options = gaflight_client_options_get_raw(options);
-    status = arrow::flight::FlightClient::Connect(*flight_location,
-                                                  *flight_options,
-                                                  &flight_client);
+     arrow::Result<std::unique_ptr<arrow::flight::FlightClient>> result = arrow::flight::FlightClient::Connect(*flight_location,
+                                                        *flight_options);
+    status = std::move(result).Value(&flight_client);

Review Comment:
   We have considered it a few times but we didn't do any actions for it.
   It may be a good time to work on it: https://issues.apache.org/jira/browse/ARROW-16137



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org