[jira] [Commented] (THRIFT-2364) OCaml: Use Oasis exclusively for build process

["James E. King, III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838719#comment-15838719 ] 

James E. King, III commented on THRIFT-2364:
--------------------------------------------

I was able to apply this to the github master, build and install.  I don't know ocaml however so I don't know if the resulting files work or not.  The only change I had to make was that I had to add "*/*.mldylib" to the .gitignore.  Also 

It looks like OCaml is not part of our standard build process (autoconf or cmake).
It looks like OCaml is not tested as part of our "make cross" testing.
I think that, in order to validate these are good changes, it would be a good idea to include OCaml as part of our docker based image and build.
I am going to open some stories for this.

> OCaml: Use Oasis exclusively for build process
> ----------------------------------------------
>
>                 Key: THRIFT-2364
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2364
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process, OCaml - Library
>         Environment: All environments
>            Reporter: Spiros Eliopoulos
>            Assignee: Spiros Eliopoulos
>            Priority: Minor
>         Attachments: THRIFT-2364.patch
>
>
> The OCaml library currently contains custom makefiles, as well as an _oasis configuration file that will generate a configuration script and Makefile. The preferred method of the community for building OCaml libraries is to use Oasis, so the other files should be dropped in favor of that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)