You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2018/04/13 05:18:01 UTC
[1/3] hbase git commit: HBASE-20338 WALProcedureStore#recoverLease()
should have fixed sleeps for retrying rollWriter() [Forced Update!]
Repository: hbase
Updated Branches:
refs/heads/HBASE-20388 855df58b1 -> 0deb8cd8a (forced update)
HBASE-20338 WALProcedureStore#recoverLease() should have fixed sleeps for retrying rollWriter()
Signed-off-by: Mike Drob <md...@apache.org>
Signed-off-by: Umesh Agashe <ua...@cloudera.com>
Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/17a29ac2
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/17a29ac2
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/17a29ac2
Branch: refs/heads/HBASE-20388
Commit: 17a29ac2313774850f0cce116ee33ef79d007a34
Parents: 70d2321
Author: Wei-Chiu Chuang <we...@cloudera.com>
Authored: Thu Apr 5 14:11:29 2018 -0700
Committer: Mike Drob <md...@apache.org>
Committed: Thu Apr 12 16:33:55 2018 -0500
----------------------------------------------------------------------
.../hbase/procedure2/store/wal/WALProcedureStore.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/17a29ac2/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
index c5680cf..f2931fc 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
@@ -359,7 +359,16 @@ public class WALProcedureStore extends ProcedureStoreBase {
lock.lock();
try {
LOG.trace("Starting WAL Procedure Store lease recovery");
+ boolean afterFirstAttempt = false;
while (isRunning()) {
+ // Don't sleep before first attempt
+ if (afterFirstAttempt) {
+ LOG.trace("Sleep {} ms after first lease recovery attempt.",
+ waitBeforeRoll);
+ Threads.sleepWithoutInterrupt(waitBeforeRoll);
+ } else {
+ afterFirstAttempt = true;
+ }
FileStatus[] oldLogs = getLogFiles();
// Get Log-MaxID and recover lease on old logs
try {
[2/3] hbase git commit: HBASE-20329 Add note for operators to
refguide on AsyncFSWAL; ADDENDUM
Posted by bu...@apache.org.
HBASE-20329 Add note for operators to refguide on AsyncFSWAL; ADDENDUM
Add small note on edits being immediately visible when Durability == ASYNC_WAL.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d59a6c81
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d59a6c81
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d59a6c81
Branch: refs/heads/HBASE-20388
Commit: d59a6c8166cf398ee62089cc35ffeddfe5824134
Parents: 17a29ac
Author: Michael Stack <st...@apache.org>
Authored: Thu Apr 12 15:59:00 2018 -0700
Committer: Michael Stack <st...@apache.org>
Committed: Thu Apr 12 16:00:11 2018 -0700
----------------------------------------------------------------------
src/main/asciidoc/_chapters/architecture.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/d59a6c81/src/main/asciidoc/_chapters/architecture.adoc
----------------------------------------------------------------------
diff --git a/src/main/asciidoc/_chapters/architecture.adoc b/src/main/asciidoc/_chapters/architecture.adoc
index bc29d4b..1d6fc60 100644
--- a/src/main/asciidoc/_chapters/architecture.adoc
+++ b/src/main/asciidoc/_chapters/architecture.adoc
@@ -1248,7 +1248,7 @@ dictionary because of an abrupt termination, a read of this last block may not b
It is possible to set _durability_ on each Mutation or on a Table basis. Options include:
* _SKIP_WAL_: Do not write Mutations to the WAL (See the next section, <<wal.disable>>).
- * _ASYNC_WAL_: Write the WAL asynchronously; do not hold-up clients waiting on the sync of their write to the filesystem but return immediately; the Mutation will be flushed to the WAL at a later time. This option currently may lose data. See HBASE-16689.
+ * _ASYNC_WAL_: Write the WAL asynchronously; do not hold-up clients waiting on the sync of their write to the filesystem but return immediately. The edit becomes visible. Meanwhile, in the background, the Mutation will be flushed to the WAL at some time later. This option currently may lose data. See HBASE-16689.
* _SYNC_WAL_: The *default*. Each edit is sync'd to HDFS before we return success to the client.
* _FSYNC_WAL_: Each edit is fsync'd to HDFS and the filesystem before we return success to the client.
[3/3] hbase git commit: HBASE-20388 nightly tests running on a
feature branch should only comment on that feature branch's jira
Posted by bu...@apache.org.
HBASE-20388 nightly tests running on a feature branch should only comment on that feature branch's jira
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0deb8cd8
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0deb8cd8
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0deb8cd8
Branch: refs/heads/HBASE-20388
Commit: 0deb8cd8a8c7545486e0808f1be71baa98fd9c04
Parents: d59a6c8
Author: Sean Busbey <bu...@apache.org>
Authored: Thu Apr 12 21:10:53 2018 -0500
Committer: Sean Busbey <bu...@apache.org>
Committed: Fri Apr 13 00:17:09 2018 -0500
----------------------------------------------------------------------
dev-support/Jenkinsfile | 35 +++++++++++++++++++++++------------
1 file changed, 23 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/0deb8cd8/dev-support/Jenkinsfile
----------------------------------------------------------------------
diff --git a/dev-support/Jenkinsfile b/dev-support/Jenkinsfile
index 3f3066b..4e249ce 100644
--- a/dev-support/Jenkinsfile
+++ b/dev-support/Jenkinsfile
@@ -497,8 +497,14 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}"
echo "[INFO] Comment:"
echo comment
echo ""
- echo "[INFO] There are ${currentBuild.changeSets.size()} change sets."
- getJirasToComment(currentBuild).each { currentIssue ->
+ echo "[DEBUG] checking to see if feature branch"
+ def jiras = getJirasToComment(env.BRANCH_NAME, [])
+ if (jiras.isEmpty()) {
+ echo "[DEBUG] non-feature branch, checking change messages for jira keys."
+ echo "[INFO] There are ${currentBuild.changeSets.size()} change sets."
+ jiras = getJirasToCommentFromChangesets(currentBuild)
+ }
+ jiras.each { currentIssue ->
jiraComment issueKey: currentIssue, body: comment
}
} catch (Exception exception) {
@@ -511,7 +517,7 @@ curl -L -o personality.sh "${env.PROJECT_PERSONALITY}"
}
import org.jenkinsci.plugins.workflow.support.steps.build.RunWrapper
@NonCPS
-List<String> getJirasToComment(RunWrapper thisBuild) {
+List<String> getJirasToCommentFromChangesets(RunWrapper thisBuild) {
def seenJiras = []
thisBuild.changeSets.each { cs ->
cs.getItems().each { change ->
@@ -521,16 +527,21 @@ List<String> getJirasToComment(RunWrapper thisBuild) {
echo " ${change.commitId}"
echo " ${change.author}"
echo ""
- msg.eachMatch("HBASE-[0-9]+") { currentIssue ->
- echo "[DEBUG] found jira key: ${currentIssue}"
- if (currentIssue in seenJiras) {
- echo "[DEBUG] already commented on ${currentIssue}."
- } else {
- echo "[INFO] commenting on ${currentIssue}."
- seenJiras << currentIssue
- }
- }
+ seenJiras = getJirasToComment(msg, seenJiras)
}
}
return seenJiras
}
+@NonCPS
+List<String> getJirasToComment(CharSequence source, CharSequence[] seen) {
+ source.eachMatch("HBASE-[0-9]+") { currentIssue ->
+ echo "[DEBUG] found jira key: ${currentIssue}"
+ if (currentIssue in seen) {
+ echo "[DEBUG] already commented on ${currentIssue}."
+ } else {
+ echo "[INFO] commenting on ${currentIssue}."
+ seen << currentIssue
+ }
+ }
+ return seen
+}