[jira] [Commented] (AMQ-7006) STOMP protocol converter tracks pending ACKS in Client mode but doesn't remove all ACK'd IDs, just the one submitted.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549855#comment-16549855 ] 

ASF subversion and git services commented on AMQ-7006:
------------------------------------------------------

Commit 9abbe826ecc47596fb43fd42e094d403c56b158d in activemq's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=9abbe82 ]

AMQ-7006 Remove STOMP pending acks after client acknowledge

Reworked patch from Avikash Mishra to remove tracked pending acks from a
STOMP subscription that has acked.

> STOMP protocol converter tracks pending ACKS in Client mode but doesn't remove all ACK'd IDs, just the one submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-7006
>                 URL: https://issues.apache.org/jira/browse/AMQ-7006
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: stomp
>    Affects Versions: 5.15.3
>            Reporter: Avikash Mishra
>            Priority: Major
>         Attachments: AMQ-7006_Remove_all_pending_acks_that_have_been_dispatched.patch
>
>
> The patch referenced in AMQ-5423 only addressed the memory leak for Client-Individual mode. Client mode is still affected as multiple messages are acknowledged with a single ACK.  The single ACK is removed from memory but all the rest remain which grows over time until AMQ crashes or until the client session ends and all the pending ACKs are cleaned up at that point.  At the moment we are having to regularly restart our STOMP clients to prevent the memory leak from causing a crash.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)