[GitHub] [commons-text] kinow commented on a change in pull request #225: TEXT-202 - Extract duplicate code

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #225:
URL: https://github.com/apache/commons-text/pull/225#discussion_r616359101



##########
File path: src/main/java/org/apache/commons/text/StrBuilder.java
##########
@@ -319,15 +319,14 @@ public StrBuilder append(final boolean value) {
             buffer[size++] = 't';
             buffer[size++] = 'r';
             buffer[size++] = 'u';
-            buffer[size++] = 'e';
         } else {
             ensureCapacity(size + 5);
             buffer[size++] = 'f';
             buffer[size++] = 'a';
             buffer[size++] = 'l';
             buffer[size++] = 's';
-            buffer[size++] = 'e';
         }
+        buffer[size++] = 'e';

Review comment:
       I prefer the other version, even though this one indeed reduces the duplication, the other version clearly shows that we have `true` and `false`, without the dev having to think why `tru` and `fals`, just to find the `e` was set out the `if/else` statement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org