[jira] Commented: (HADOOP-3048) Stringifier

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580268#action_12580268 ] 

Enis Soztutar commented on HADOOP-3048:
---------------------------------------

For completeness, I will repeat Chris Douglas' comments about the implementation here : 

* DefaultStringifier could reuse more of the objects it creates. The serializer will hold a reference to the ByteArray(Input/Output)Buffers you've defined, so re-opening and closing them every time is unnecessary if you use a resetable stream like o.a.h.io.Data(Input/Output)Buffer.
 * The static convenience methods (load, store, storeArray) that create new Stringifiers in DefaultStringifier are probably unnecessary. Adding a stringified object to a config doesn't need that much support. 
 * Further, it's not clear to me how one would register a Stringifier that isn't a DefaultStringifier. Would it make sense to follow the pattern in the Serialization framework from HADOOP-1986- or the WritableComparator static initialization- and register custom Stringifiers for classes?


> Stringifier
> -----------
>
>                 Key: HADOOP-3048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3048
>             Project: Hadoop Core
>          Issue Type: New Feature
>    Affects Versions: 0.17.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.17.0
>
>         Attachments: stringifier_v1.patch
>
>
> Storing arbitrary objects in the configuration has been discussed before in HADOOP-449 and HADOOP-1873. Although enabling such functionality has the risk of encouraging people to put big binary objects in the configuration, for some use cases passing objects to tasks is absolutely necessary. 
> This issue will track the implementation of a Stringifier interface which stringifies and destringifies objects. Using this implementation, developers can store objects in the configuration and restore them later. 
> Any thoughts ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.