[GitHub] [cloudstack] DaanHoogland commented on issue #4061: [VMware] Cannot migrate VM on PVLAN shared network

[GitBox <gi...@apache.org>]

DaanHoogland commented on issue #4061:
URL: https://github.com/apache/cloudstack/issues/4061#issuecomment-625689410


   > Strangely, assert check passes but casting fails:
   > 
   > ```
   > } else if (vm.getType() == VirtualMachine.Type.User) {
   >             assert vm instanceof UserVmVO;
   >             final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();
   >             _userVmMgr.setupVmForPvlan(false, userVm.getHostId(), nic);
   > }
   > ```
   
   Are yousure you ran with asserts turned on? better make this a regular java check, as hardly ever the system is tested with asserts on.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org