You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "m-gorecki (via GitHub)" <gi...@apache.org> on 2026/10/02 13:44:19 UTC
[PR] hw/mcu/nordic: Enable crypto_nrf driver support on nrf5340_net [mynewt-core]
m-gorecki opened a new pull request, #3751:
URL: https://github.com/apache/mynewt-core/pull/3751
This enables hardware AES encryption support and can be used
with mbedtls alt functions to reduce flash and ram usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/mcu/nordic: Enable crypto_nrf driver support on nrf5340_net [mynewt-core]
Posted by "m-gorecki (via GitHub)" <gi...@apache.org>.
m-gorecki merged PR #3751:
URL: https://github.com/apache/mynewt-core/pull/3751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/mcu/nordic: Enable crypto_nrf driver support on nrf5340_net [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #3751:
URL: https://github.com/apache/mynewt-core/pull/3751#discussion_r4249254941
##########
hw/mcu/nordic/nrf5340_net/pkg.yml:
##########
@@ -43,9 +43,12 @@ pkg.deps.SPI_0_MASTER:
- "@apache-mynewt-core/hw/bus"
- "@apache-mynewt-core/hw/bus/drivers/spi_hal"
-pkg.deps.I2C_0':
+pkg.deps.I2C_0:
Review Comment:
should be separate commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/mcu/nordic: Enable crypto_nrf driver support on nrf5340_net [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #3751:
URL: https://github.com/apache/mynewt-core/pull/3751#discussion_r4249253059
##########
hw/mcu/nordic/nrf5340_net/src/nrf5340_net_periph.c:
##########
@@ -177,6 +186,21 @@ nrf5340_net_periph_create_trng(void)
#endif
}
+static void
+nrf5340_net_periph_create_crypto(void)
+{
+ int rc;
Review Comment:
whole body can be under #ifdef
##########
hw/mcu/nordic/nrf5340_net/pkg.yml:
##########
@@ -43,9 +43,12 @@ pkg.deps.SPI_0_MASTER:
- "@apache-mynewt-core/hw/bus"
- "@apache-mynewt-core/hw/bus/drivers/spi_hal"
-pkg.deps.I2C_0':
+pkg.deps.I2C_0:
Review Comment:
should be separate commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/mcu/nordic: Enable crypto_nrf driver support on nrf5340_net [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #3751:
URL: https://github.com/apache/mynewt-core/pull/3751#issuecomment-6126697325
oh and fix style and commit messages before un-drafting ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org