You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/10 01:03:31 UTC

[GitHub] [tvm] masahi commented on a change in pull request #7074: Fix QNN type inference

masahi commented on a change in pull request #7074:
URL: https://github.com/apache/tvm/pull/7074#discussion_r539764667



##########
File path: src/relay/qnn/op/op_common.h
##########
@@ -171,6 +171,11 @@ static inline bool QnnBroadcastRel(const Array<Type>& types, int num_inputs, con
   ICHECK_EQ(types.size(), kNumQnnBinaryOpArgTypes);
 
   // Check the scale and zero point types
+  for (size_t i = 0; i < 8; ++i) {

Review comment:
       because this is binary operator, it has scales and zps for both lhs an rhs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org