You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (Created) (JIRA)" <ji...@apache.org> on 2012/04/20 02:32:42 UTC
[jira] [Created] (HDFS-3306) fuse_dfs: don't lock release
operations
fuse_dfs: don't lock release operations
---------------------------------------
Key: HDFS-3306
URL: https://issues.apache.org/jira/browse/HDFS-3306
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Colin Patrick McCabe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3306:
---------------------------------------
Attachment: HDFS-3306.001.patch
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413397#comment-13413397 ]
Hudson commented on HDFS-3306:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2460 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2460/])
HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Colin Patrick McCabe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258420#comment-13258420 ]
Colin Patrick McCabe commented on HDFS-3306:
--------------------------------------------
To test this, I mounted a fuse_dfs filesystem, created a bunch of files, and then deleted them.
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HDFS-3306) fuse_dfs: don't lock release operations
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HDFS-3306.
-------------------------------
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413756#comment-13413756 ]
Hudson commented on HDFS-3306:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1135 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/])
HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413422#comment-13413422 ]
Hudson commented on HDFS-3306:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2479 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2479/])
HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413400#comment-13413400 ]
Hudson commented on HDFS-3306:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2526 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2526/])
HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3306:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Per offline conversation Colin tested this multithreaded.
+1 I've committed this and merged to branch-2.
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262315#comment-13262315 ]
Eli Collins commented on HDFS-3306:
-----------------------------------
Check the parallel case, eg multiple threads cat'ing the same set of files in parallel (will result in open/release on the same files)?
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413666#comment-13413666 ]
Hudson commented on HDFS-3306:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1102 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/])
HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Colin Patrick McCabe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3306:
---------------------------------------
Status: Patch Available (was: Open)
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258009#comment-13258009 ]
Eli Collins commented on HDFS-3306:
-----------------------------------
Agree with your logic, and the change looks good. Testing?
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3306) fuse_dfs: don't lock release
operations
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257975#comment-13257975 ]
Hadoop QA commented on HDFS-3306:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523439/HDFS-3306.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//console
This message is automatically generated.
> fuse_dfs: don't lock release operations
> ---------------------------------------
>
> Key: HDFS-3306
> URL: https://issues.apache.org/jira/browse/HDFS-3306
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3306.001.patch
>
>
> There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira