You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/26 08:12:59 UTC

[GitHub] [iotdb] qiaojialin commented on a change in pull request #2739: Fix unseq merge data overlap bug

qiaojialin commented on a change in pull request #2739:
URL: https://github.com/apache/iotdb/pull/2739#discussion_r583455132



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/selector/MaxFileMergeFileSelector.java
##########
@@ -228,7 +227,7 @@ private void selectOverlappedSeqFiles(TsFileResource unseqFile) {
         if (seqSelected[i] || !seqFile.getDevices().contains(deviceId)) {
           continue;
         }
-        long seqEndTime = seqFile.getEndTime(deviceId);
+        long seqEndTime = seqFile.isClosed() ? seqFile.getEndTime(deviceId) : Long.MAX_VALUE;

Review comment:
       add a javadoc for TsFileResource.getEndTime()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org