[GitHub] [helix] junkaixue commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r748503217



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       This is the fix for recent asking, right? I have not tested but I am not sure if we pass empty map in customize check would cause problem?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org