You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 04:40:54 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1881: chore: refactored test login.spec.js

liuxiran commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629840470



##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -17,39 +17,45 @@
 /* eslint-disable no-undef */
 
 context('Login Test', () => {
+  const selector = {
+    errorExplain: '.ant-form-item-explain',
+    usernameInput: '#control-ref_username',
+    passwordInput: '#control-ref_password',
+    notification: '.ant-notification-notice-message',
+  };
+

Review comment:
       do we need to define `data`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org