You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/19 10:51:27 UTC

[GitHub] [incubator-nuttx] j4r0u53k opened a new pull request #3110: Add CAN FD flags to can header

j4r0u53k opened a new pull request #3110:
URL: https://github.com/apache/incubator-nuttx/pull/3110


   ## Summary
   
   The first commit 333345a adds EDL, BRS and ESI bits added to struct can_hdr_s.
   
   The `ch_unused' field is useless (adjacent fields in packed structs are aligned to the next byte), but some
   drivers explicitly set this field to zero, so it is kept therefor backward compatibility on the API.
   
   When started using DLC > 8 a bug in can_write was revealed. This is fixed (or I would better say work arounded with respect to keeping maximum backward compatibility and not possibly breaking other components) in commit 571dd60.
   
   ## Impact
   
   These changes are API backward compatible.
   
   ## Testing
   
   Tested on Bosch M_CAN controller on SAMv7 chip (needs additional changes to that driver not included in this pull request).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3110: Add CAN FD flags to CAN header

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3110:
URL: https://github.com/apache/incubator-nuttx/pull/3110#issuecomment-803084208


   @j4r0u53k please fetch the latest master, rebase your change and push -f again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3110: Add CAN FD flags to CAN header

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3110:
URL: https://github.com/apache/incubator-nuttx/pull/3110


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org