[jira] [Commented] (MESOS-5131) DRF allocator crashes master with CHECK when resource is incorrect

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229212#comment-15229212 ] 

Joseph Wu commented on MESOS-5131:
----------------------------------

Ideally, this check should also happen here: https://github.com/apache/mesos/blob/18f60da868b07885fc2c29b4494054dd9bc871a6/src/slave/slave.cpp#L4961

But the allocator check should probably stay, since the allocator could get into a bad state if non-revocable resources are somehow oversubscribed.

> DRF allocator crashes master with CHECK when resource is incorrect
> ------------------------------------------------------------------
>
>                 Key: MESOS-5131
>                 URL: https://issues.apache.org/jira/browse/MESOS-5131
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation, oversubscription
>            Reporter: Zhitao Li
>            Priority: Critical
>
> We were testing a custom resource estimator which broadcasts oversubscribed resources, but they are not marked as "revocable".
> This unfortunately triggered the following check in hierarchical allocator:
> {quote}
> void HierarchicalAllocatorProcess::updateSlave(     
>   // Check that all the oversubscribed resources are revocable.
>   CHECK_EQ(oversubscribed, oversubscribed.revocable());
> {quote}
> This definitely shouldn't happen in production cluster. IMO, we should do both of following:
> 1. Make sure incorrect resource is not sent from agent (even crash agent process is better);
> 2. Decline agent registration if it's resources is incorrect, or even tell it to shutdown, and possibly remove this check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)