You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/01/08 08:55:18 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
susiwen8 opened a new pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992
…or tooltip
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Add `returnFirstMatch` for `tooltip`
### Fixed issues
Close #13971
## Details
### Before: What was the problem?
### After: How is it fixed in this PR?
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-757086305
Thanks for the fix!! https://github.com/apache/incubator-echarts/blob/c4bcc97ee2a0d521872b73f2ebfa9df69fcffac4/src/component/tooltip/TooltipView.ts#L432 seems should add this parameter too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-756634047
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-756749035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-756634047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-757086305
Thanks for the fix!! https://github.com/apache/incubator-echarts/blob/c4bcc97ee2a0d521872b73f2ebfa9df69fcffac4/src/component/tooltip/TooltipView.ts#L432 seems should add this parameter too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-757087086
> Thanks for the fix!!
>
> https://github.com/apache/incubator-echarts/blob/c4bcc97ee2a0d521872b73f2ebfa9df69fcffac4/src/component/tooltip/TooltipView.ts#L432
>
> seems should add this parameter too.
@pissang Right, I have missed it.`returnFirstMatch` has been added now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-757131893
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992#issuecomment-756749035
test case: `Tooltip in Stacked Bar Chart (check MarkPoint)` in `new-tooltip.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13992: Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' f…
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13992:
URL: https://github.com/apache/incubator-echarts/pull/13992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org