You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/04/22 02:49:05 UTC

Review Request 58646: Fixed a style issue in v1 mesos.proto.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58646/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Artem Harutyunyan.


Bugs: MESOS-4263
    https://issues.apache.org/jira/browse/MESOS-4263


Repository: mesos


Description
-------

Fixed a style issue in v1 mesos.proto.


Diffs
-----

  include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 


Diff: https://reviews.apache.org/r/58646/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 58646: Fixed a style issue in v1 mesos.proto.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58646/#review172742
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58641, 58642, 58643, 58644, 58645, 58646]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 22, 2017, 2:49 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58646/
> -----------------------------------------------------------
> 
> (Updated April 22, 2017, 2:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4263
>     https://issues.apache.org/jira/browse/MESOS-4263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a style issue in v1 mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 
> 
> 
> Diff: https://reviews.apache.org/r/58646/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 58646: Fixed a style issue in v1 mesos.proto.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58646/#review172835
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On April 21, 2017, 7:49 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58646/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 7:49 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4263
>     https://issues.apache.org/jira/browse/MESOS-4263
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a style issue in v1 mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608 
> 
> 
> Diff: https://reviews.apache.org/r/58646/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>