You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/17 02:30:47 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11010: [Feature][Task Plugin] Increase zeppelin task stability in production

kezhenxu94 commented on code in PR #11010:
URL: https://github.com/apache/dolphinscheduler/pull/11010#discussion_r922760457


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java:
##########
@@ -77,12 +78,21 @@ public void setRestEndpoint(String restEndpoint) {
         this.restEndpoint = restEndpoint;
     }
 
+    public String getproductionNoteDirectory() {
+        return productionNoteDirectory;
+    }
+
+    public void setproductionNoteDirectory(String productionNoteDirectory) {
+        this.productionNoteDirectory = productionNoteDirectory;
+    }
+
     @Override
     public String toString() {
         return "ZeppelinParameters{"
                + "noteId='" + noteId + '\''
-               + ", paragraphId='" + paragraphId + '\''
+               + ", paragraphId='" + paragraphId + '\'' 

Review Comment:
   Can you help to also refactor this class to use lombok annotations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org