You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@toree.apache.org by lr...@apache.org on 2023/08/10 16:44:33 UTC
[incubator-toree] branch master updated: [TOREE-543] Fix and enable JVMReprSpec (#209)
This is an automated email from the ASF dual-hosted git repository.
lresende pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-toree.git
The following commit(s) were added to refs/heads/master by this push:
new 46347728 [TOREE-543] Fix and enable JVMReprSpec (#209)
46347728 is described below
commit 46347728beb9ca280c05a99add131e9bcdfbaa8c
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Fri Aug 11 00:44:27 2023 +0800
[TOREE-543] Fix and enable JVMReprSpec (#209)
---
scala-interpreter/build.sbt | 1 +
.../org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala | 2 +-
.../src/test/scala/integration/interpreter/scala/JVMReprSpec.scala | 3 +--
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scala-interpreter/build.sbt b/scala-interpreter/build.sbt
index 39dcb023..416c3d7f 100644
--- a/scala-interpreter/build.sbt
+++ b/scala-interpreter/build.sbt
@@ -17,5 +17,6 @@ import sbt.Tests.{Group, SubProcess}
* limitations under the License
*/
+Test / fork := true
libraryDependencies ++= Dependencies.sparkAll.value
libraryDependencies += "com.github.jupyter" % "jvm-repr" % "0.1.0"
diff --git a/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala b/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala
index 82b7c9b7..1938719e 100644
--- a/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala
+++ b/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala
@@ -155,7 +155,7 @@ class ScalaInterpreter(private val config:Config = ConfigFactory.load) extends I
doQuietly {
bind(
- "kernel", "org.apache.toree.kernel.api.Kernel",
+ "kernel", "org.apache.toree.kernel.api.KernelLike",
kernel, List( """@transient implicit""")
)
}
diff --git a/scala-interpreter/src/test/scala/integration/interpreter/scala/JVMReprSpec.scala b/scala-interpreter/src/test/scala/integration/interpreter/scala/JVMReprSpec.scala
index 0d10834a..2cd7447f 100644
--- a/scala-interpreter/src/test/scala/integration/interpreter/scala/JVMReprSpec.scala
+++ b/scala-interpreter/src/test/scala/integration/interpreter/scala/JVMReprSpec.scala
@@ -28,13 +28,12 @@ import org.apache.toree.interpreter.Results.Success
import org.apache.toree.kernel.api.{DisplayMethodsLike, KernelLike}
import org.apache.toree.kernel.interpreter.scala.ScalaInterpreter
import org.mockito.Mockito.doReturn
-import org.scalatest.{BeforeAndAfter, FunSpec, Ignore, Matchers}
+import org.scalatest.{BeforeAndAfter, FunSpec, Matchers}
import org.scalatestplus.mockito.MockitoSugar
import scala.util.Random
@SbtForked
-@Ignore
class JVMReprSpec extends FunSpec with Matchers with MockitoSugar with BeforeAndAfter {
private val outputResult = new ByteArrayOutputStream()