You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 11:43:54 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1861: Faster StringDictionaryBuilder (~60% faster) (#1851)

tustvold commented on code in PR #1861:
URL: https://github.com/apache/arrow-rs/pull/1861#discussion_r895623151


##########
arrow/Cargo.toml:
##########
@@ -38,9 +38,11 @@ path = "src/lib.rs"
 bench = false
 
 [dependencies]
+ahash = "0.7"
 serde = { version = "1.0" }
 serde_derive = "1.0"
 serde_json = { version = "1.0", features = ["preserve_order"] }
+hashbrown = "0.12"

Review Comment:
   This is "technically" a new dependency as indexmap depends on `hashbrown = 0.11`, I wasn't sure whether to use an out of data dependency or not here...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org