[GitHub] ippeiukai commented on issue #564: Specifying a directory of .java files as source-file src no longer works

[GitBox <gi...@apache.org>]

ippeiukai commented on issue #564: Specifying a directory of .java files as source-file src no longer works
URL: https://github.com/apache/cordova-android/issues/564#issuecomment-439749030
 
 
   I’m not fun of the whole source-file element situation to be honest.
   I feel it is already compromised when it allowed any file to be copied into the target dir inside Cordova project. It’s not just directory as src feature.
   To me, specifying a directory of .java files is far more aligned with the purpose of source-file element than specifying individual .so or .a files. But that’s matter of personal opinion. My point is that it’s not just the directory that should be deprecated.
   
   The documentation on the target-dir attribute reads as follows:
   
   > A directory into which the files should be copied, relative to the root of the Cordova project. 
   
   (https://cordova.apache.org/docs/en/8.x/plugin_ref/spec.html#source-file)
   
   Note that cordova-android has diverged from the above documented behaviour in 7.x by replacing parts of specified path for backward compatibility. In fact, the undocumented feature described in this issue is broken (more like left behind) in that process.
   
   As @brodybits says discussion should be continued on https://github.com/apache/cordova/issues/47.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org