[jira] [Comment Edited] (SUREFIRE-1743) Allow custom listeners to request stop

["Tibor Digana (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012301#comment-17012301 ] 

Tibor Digana edited comment on SUREFIRE-1743 at 1/9/20 11:43 PM:
-----------------------------------------------------------------

Of course, splitting accordingly is not on the table because there wouldn't be a dramatic rework to a broken compatibility of API in a near future which normally turns to the major version 6.0. As in the history, one may see that JUnit 4.8.1 modified the acess point interface {{JUnitCore}} and broke the backwards compatibility. Additionally, the Junit introduced important interface {{Computer}} for {{surefire-junit47}} provider which is part of {{JUnitCore}}. And this was a dramatic change because the parallel tests were executed in different manner which changed the behavior of the plugin for non-parallel tests as well.


was (Author: tibor17):
Of course, splitting accordingly is not on the table because there wouldn't be a dramatic rework to a broken compatibility of API in a near future which normally turns to the major version 6.0. As in the history, one may see that JUnit 4.8.1 modified the acess point interface {{JUnitCore}} and broke the backwards compatibility. Additionally, the Junit introduced important interface {{Computer}} for {{surefire-junit47}} provider which is part of {{JUnitCore}} and this was dramatic change because the parallel tests were executed in different manner which changed the behavior of the plugin for non-parallel tests as well.

> Allow custom listeners to request stop
> --------------------------------------
>
>                 Key: SUREFIRE-1743
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1743
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: documentation, JUnit 5.x support, Maven Failsafe Plugin, Maven Surefire Plugin
>            Reporter: Andrew Neeson
>            Priority: Major
>
> Currently Surefire gives you the ability to [add custom listeners and reporters|https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html#Using_Custom_Listeners_and_Reporters].  However, those listeners do not have a hook on the Notifier which created them.
> I would like to be able to create listeners which have the ability to request that the test run is stopped (RunNotifier.pleaseStop) under specific conditions.  These conditions are not currently covered by existing mechanisms such as [skipAfterFailure|https://maven.apache.org/surefire/maven-surefire-plugin/examples/skip-after-failure.html].
> Note:  I originally considered this as [a change to Cucumber JVM|https://github.com/cucumber/cucumber-jvm/issues/1854], but I realise that it's more generic than that (hence this ticket).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)