[jira] [Commented] (MSHADE-326) Hide shaded dependencies from the rest of the reactor build

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365486#comment-17365486 ] 

Michael Osipov commented on MSHADE-326:
---------------------------------------

The description does not make sense. Maven never reads the POM from JAR/WAR, etc. Maven either uses the reactor or download the POM from a repo directory. Please clarify.

> Hide shaded dependencies from the rest of the reactor build
> -----------------------------------------------------------
>
>                 Key: MSHADE-326
>                 URL: https://issues.apache.org/jira/browse/MSHADE-326
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.1
>            Reporter: Niels Basjes
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When building a multi module project the following effect occurs:
> 1) A module with functionality is build ("library") that shades (and relocates) some of the  dependencies into the jar file. With https://issues.apache.org/jira/browse/MSHADE-36 in place this jar file has the correct transitive dependencies specified in the jar.
> 2) However when another module in the same project ("tool") uses that library the reactor will NOT look at the dependencies specified in the jar of the library. It will look at the dependencies specified in the original pom.xml of the library.
> The effect is that the "tool" will have all dependencies of the "library" twice: Once from the library jar (possibly relocated) and once from the transitive dependencies passed on via the reactor.
>  
> Proposed change: 
> 1) Extra flag to enable this feature
> 2) If enabled the dependencies in the reactor are modified to match the dependencies in the actual jar file.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)