You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/09 14:07:45 UTC
Review Request 42106: Added helper function to return Error in
condition.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42106/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Added helper function to return Error in condition.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 1e9db7e
Diff: https://reviews.apache.org/r/42106/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 42106: Added helper function to return Error in
condition.
Posted by Klaus Ma <kl...@gmail.com>.
> On Jan. 12, 2016, 2:03 a.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp, line 57
> > <https://reviews.apache.org/r/42106/diff/1/?file=1189254#file1189254line57>
> >
> > Why is there a redundant `while` here?
It's used to avoid un-expected behaviour, for example:
if (condition1)
RETURN_ERROR_IF(...)
else
do something else
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42106/#review113804
-----------------------------------------------------------
On Jan. 9, 2016, 9:09 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42106/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 9:09 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to return Error in condition.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 1e9db7e
>
> Diff: https://reviews.apache.org/r/42106/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42106: Added helper function to return Error in
condition.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42106/#review113804
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp (line 57)
<https://reviews.apache.org/r/42106/#comment174607>
Why is there a redundant `while` here?
- Joseph Wu
On Jan. 9, 2016, 5:09 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42106/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 5:09 a.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to return Error in condition.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 1e9db7e
>
> Diff: https://reviews.apache.org/r/42106/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 42106: Added helper function to return Error in
condition.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42106/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 9:09 p.m.)
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Added helper function to return Error in condition.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 1e9db7e
Diff: https://reviews.apache.org/r/42106/diff/
Testing
-------
Thanks,
Klaus Ma