You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2025/01/07 19:21:55 UTC

[I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

pitrou opened a new issue, #45193:
URL: https://github.com/apache/arrow/issues/45193

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   Expected (NaNs and nulls are distinct, ordered according to `null_placement`):
   ```python
   >>> a = pa.array([1, None, math.nan, 2, math.nan, None])
   >>> pc.rank(a, tiebreaker='min', null_placement='at_end')
   <pyarrow.lib.UInt64Array object at 0x7f168295ca00>
   [
     1,
     5,
     3,
     2,
     3,
     5
   ]
   >>> pc.rank(a, tiebreaker='min', null_placement='at_start')
   <pyarrow.lib.UInt64Array object at 0x7f1682845600>
   [
     5,
     1,
     3,
     6,
     3,
     1
   ]
   ```
   
   Actual (NaNs and nulls are considered ties):
   ```python
   >>> pc.rank(a, tiebreaker='min', null_placement='at_end')
   <pyarrow.lib.UInt64Array object at 0x7f1682951660>
   [
     1,
     3,
     3,
     2,
     3,
     3
   ]
   >>> pc.rank(a, tiebreaker='min', null_placement='at_start')
   <pyarrow.lib.UInt64Array object at 0x7f1682845600>
   [
     5,
     1,
     1,
     6,
     1,
     1
   ]
   ```
   
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #45193: [C++][Compute] Rank function considers NaNs and nulls equal
URL: https://github.com/apache/arrow/issues/45193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-2586646462

   Hi @timgrein , yes, I think it would be a good issue to start if you already have some familiarity with the basic Arrow C++ APIs. **However,** there is a refactor going on in https://github.com/apache/arrow/pull/45217 (probably soon merged), so you should probably base your work on that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "curioustien (via GitHub)" <gi...@apache.org>.
curioustien commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-2708629008

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "abhishek593 (via GitHub)" <gi...@apache.org>.
abhishek593 commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-3912817387

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-2587139194

   Update: the aforementioned PR was merged, so you can start from git `main` :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-4286801552

   Issue resolved by pull request 49304
   https://github.com/apache/arrow/pull/49304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "timgrein (via GitHub)" <gi...@apache.org>.
timgrein commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-2585257287

   Hey 👋 
   
   Recently started to look more deeply into Arrow, I would love to get my hands dirty with some smaller issues. Do you think this is one is a good starting point? If yes, I would like to give it a shot :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++][Compute] Rank function considers NaNs and nulls equal [arrow]

Posted by "curioustien (via GitHub)" <gi...@apache.org>.
curioustien commented on issue #45193:
URL: https://github.com/apache/arrow/issues/45193#issuecomment-2661925503

   I can take a stab at this during my free time too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org