You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:30:22 UTC
[GitHub] [phoenix] richardantal opened a new pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
richardantal opened a new pull request #953:
URL: https://github.com/apache/phoenix/pull/953
…p gives version as 4.15.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #953:
URL: https://github.com/apache/phoenix/pull/953#discussion_r516581750
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java
##########
@@ -83,4 +85,13 @@ public void testHandleCreateTableMutationCodeWithNewCode() throws SQLException {
}
}
+ @Test
+ public void testMetaDataProtocolVersion() {
+ long serversTimstamp = System.currentTimeMillis();
+ String version = MetaDataProtocol.getVersion(serversTimstamp);
+ assertEquals("4.16.x", version); // We have to update it after every release
+ assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, "x"),
Review comment:
I believe this assert might be better fit for all branches and the one above `assertEquals("4.16.x", version);` might not be needed. Thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #953:
URL: https://github.com/apache/phoenix/pull/953#issuecomment-721359001
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 3s | 4.x passed |
| +1 :green_heart: | compile | 0m 53s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 39s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 953 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 17s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 38s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 3s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 127m 22s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 158m 1s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.ViewIT |
| | phoenix.end2end.index.GlobalMutableNonTxIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/953 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 26c002ff65c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 8aa243d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/testReport/ |
| Max. process+thread count | 6949 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] richardantal commented on a change in pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
richardantal commented on a change in pull request #953:
URL: https://github.com/apache/phoenix/pull/953#discussion_r516604261
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java
##########
@@ -83,4 +85,13 @@ public void testHandleCreateTableMutationCodeWithNewCode() throws SQLException {
}
}
+ @Test
+ public void testMetaDataProtocolVersion() {
+ long serversTimstamp = System.currentTimeMillis();
+ String version = MetaDataProtocol.getVersion(serversTimstamp);
+ assertEquals("4.16.x", version); // We have to update it after every release
+ assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, "x"),
Review comment:
Yeah, that is right!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #953:
URL: https://github.com/apache/phoenix/pull/953#issuecomment-720680092
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 59s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 8s | phoenix-core in 4.x has 953 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 11s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 37s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 18s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 198m 32s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 232m 12s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.FlappingLocalIndexIT |
| | phoenix.end2end.IndexExtendedIT |
| | phoenix.end2end.salted.SaltedTableIT |
| | phoenix.end2end.DerivedTableIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/953 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 16f7a7438785 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / a8a9699 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/testReport/ |
| Max. process+thread count | 3468 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #953:
URL: https://github.com/apache/phoenix/pull/953#issuecomment-720753361
Change itself looks good, @richardantal , but could we please have a simple test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] richardantal commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
richardantal commented on pull request #953:
URL: https://github.com/apache/phoenix/pull/953#issuecomment-720985224
Thanks @gjacoby126 for the review.
I wrote a test but we will have to update this version after releases.
I also checked the failing tests and the were successful locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #953:
URL: https://github.com/apache/phoenix/pull/953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org