You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/08/08 03:51:55 UTC
(datafusion) 01/01: fix: box aws-config loading future avoid clippy warning (#24175)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-24175-634f0b3004af274b0a3d8230710090447c53f352
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit 1cb89d2b8134ed76a8324bbc14f75239bb020b7c
Author: Neil Conway <ne...@gmail.com>
AuthorDate: Fri Aug 7 23:51:31 2026 -0400
fix: box aws-config loading future avoid clippy warning (#24175)
## Which issue does this PR close?
- N/A
## Rationale for this change
In aws-config >= 1.10, the future returned by `ConfigLoader::load()` is
large enough that it triggers the clippy `large_futures` error (as seen
in the CI failures for #24163). Fix this by using `Box::pin`.
## What changes are included in this PR?
See above.
## Are these changes tested?
Yes.
## Are there any user-facing changes?
No.
---
datafusion-cli/src/object_storage.rs | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/datafusion-cli/src/object_storage.rs b/datafusion-cli/src/object_storage.rs
index e2ba992961..5e6337e303 100644
--- a/datafusion-cli/src/object_storage.rs
+++ b/datafusion-cli/src/object_storage.rs
@@ -180,7 +180,10 @@ struct CredentialsFromConfig {
impl CredentialsFromConfig {
/// Attempt find AWS S3 credentials via the AWS SDK
pub async fn try_new() -> Result<Self> {
- let config = aws_config::defaults(BehaviorVersion::latest()).load().await;
+ // Loading the SDK config produces a large future, so box it to avoid
+ // potentially triggering the `large_futures` clippy lint.
+ let config =
+ Box::pin(aws_config::defaults(BehaviorVersion::latest()).load()).await;
let region = config.region().map(|r| r.to_string());
let credentials = config
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org