You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/08/13 15:55:05 UTC
[PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
alamb opened a new pull request, #17175:
URL: https://github.com/apache/datafusion/pull/17175
Note this targets `branch-49`, not main
I plan to regenerate the changelog one more time once the final PRs have been merged
## Which issue does this PR close?
- part of https://github.com/apache/datafusion/issues/17036
## Rationale for this change
Prepare for the release
## What changes are included in this PR?
1. Update version to `49.0.1`
2. Generate changelog. See rendered version
I generated the changelog like this
```shell
./dev/release/generate-changelog.py 49.0.0 branch-49 49.0.1 > dev/changelog/49.0.1.md
npx prettier -w dev/changelog/49.0.1.md
```
## Are these changes tested?
By CI
## Are there any user-facing changes?
New version/changelog
Note once this PR merges I will forward port it to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#issuecomment-3188635910
I have also made a PR to bring these changes to main
- https://github.com/apache/datafusion/pull/17191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276781064
##########
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##########
@@ -536,7 +536,7 @@ COPY (
'2023-10-01 00:00:00'::timestamptz AS start_timestamp,
'prod' as deployment_environment
)
-TO 'data/1.parquet';
+TO 'test_files/scratch/parquet_filter_pushdown/data/1.parquet';
Review Comment:
Forward port
- https://github.com/apache/datafusion/pull/17191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on code in PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276420783
##########
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##########
@@ -536,7 +536,7 @@ COPY (
'2023-10-01 00:00:00'::timestamptz AS start_timestamp,
'prod' as deployment_environment
)
-TO 'data/1.parquet';
+TO 'test_files/scratch/parquet_filter_pushdown/data/1.parquet';
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#issuecomment-3188591723
Thanks for the approvals @andygrove and @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276278938
##########
datafusion/sqllogictest/test_files/joins.slt:
##########
@@ -4240,23 +4240,23 @@ set datafusion.execution.target_partitions = 1;
# Note we use csv as MemoryExec does not support limit push down (so doesn't manifest
# bugs if limits are improperly pushed down)
query I
-COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/limit/t1.csv'
+COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/joins/t1.csv'
Review Comment:
This test was failing on the branch. Here is an example https://github.com/apache/datafusion/actions/runs/16948253306/job/48035037022?pr=17175
<img width="1434" height="171" alt="Screenshot 2025-08-14 at 6 50 01 AM" src="https://github.com/user-attachments/assets/7080ae8d-767c-4a91-8e89-173dc902e9db" />
The issue is that it is using the wrong scratch space. This was fixed by @2010YOUY01 on main in
- https://github.com/apache/datafusion/pull/16880
- (and a check to prevent it from happening again added in https://github.com/apache/datafusion/pull/17017)
I backported the fix to this PR to get a clean CI run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17175:
URL: https://github.com/apache/datafusion/pull/17175#discussion_r2276256424
##########
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##########
@@ -536,7 +536,7 @@ COPY (
'2023-10-01 00:00:00'::timestamptz AS start_timestamp,
'prod' as deployment_environment
)
-TO 'data/1.parquet';
+TO 'test_files/scratch/parquet_filter_pushdown/data/1.parquet';
Review Comment:
It seems like the test was previously writing data to `datafusion/sqllogictest/data/1.parquet` and `datafusion/sqllogictest/data/2.parquet` which are also checked in
This means that when the new files are written (with a new datafusion version string) they are different which failed the "working directory clean" check. Here is an example: https://github.com/apache/datafusion/actions/runs/16942532196/job/48015583433?pr=17175
<img width="951" height="278" alt="Screenshot 2025-08-14 at 6 39 19 AM" src="https://github.com/user-attachments/assets/62261cdf-9286-4e7c-9d21-bd6c84400198" />
I changed this test to properly use the scratch location instead
(I will port this to main as well once we release 49.0.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [branch-49] Update version to 49.0.1 and add changelog [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #17175:
URL: https://github.com/apache/datafusion/pull/17175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org