You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shaynativ <gi...@git.apache.org> on 2017/03/29 11:36:25 UTC
[GitHub] spark pull request #17466: Added getter for impurityStats
GitHub user shaynativ opened a pull request:
https://github.com/apache/spark/pull/17466
Added getter for impurityStats
Adding a simple getter method for the impurity stats.
I'm using this in https://github.com/RedisLabs/spark-redis-ml to export the stats to Redis.
No tests added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaynativ/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17466
----
commit 596719c081fbeaf51e624474f40d35a319498f9f
Author: Shay Nativ <sh...@gmail.com>
Date: 2017-01-11T09:51:44Z
Added getter for impurityStats
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: [SPARK-14681][ML] Added getter for impurityStats
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17466
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: Added getter for impurityStats
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17466
Hi @shaynativ, this PR looks a non-trivial change that needs a JIRA. Please refer http://spark.apache.org/contributing.html.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17466: [SPARK-14681][ML] Added getter for impurityStats
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17466
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: [SPARK-14681][ML] Added getter for impurityStats
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/17466
@shaynativ Sorry for the inactivity here. Btw, for the JIRA & PR title question above, I'd recommend checking out http://spark.apache.org/contributing.html
Since @WeichenXu123 opened a fresh PR for this, would you mind working with him on it?
We can close this issue / PR for now. Thank you!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: Added getter for impurityStats
Posted by shaynativ <gi...@git.apache.org>.
Github user shaynativ commented on the issue:
https://github.com/apache/spark/pull/17466
It looks like there is a JIRA issue for this:
[SPARK-14681](https://issues.apache.org/jira/browse/SPARK-14681)
How should I proceed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: Added getter for impurityStats
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17466
If you think it is the JIRA, fix the title to `[SPARK-14681][ML] Added getter for impurityStats`. That would make a link to the JIRA automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: Added getter for impurityStats
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17466
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: [SPARK-14681][ML] Added getter for impurityStats
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17466
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17466: [SPARK-14681][ML] Added getter for impurityStats
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17466
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org