[jira] [Comment Edited] (OAK-7630) Suggest directory update doesn't close AnalyzingInfixSuggester after building

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542344#comment-16542344 ] 

Vikas Saurabh edited comment on OAK-7630 at 7/19/18 12:27 PM:
--------------------------------------------------------------

Fixed on trunk at [r1835780|https://svn.apache.org/r1835780]. -Would backport to 1.8 branch after a few cycles of testing.- Backported to 1.8 at [r1836267|https://svn.apache.org/r1836267].


was (Author: catholicon):
Fixed on trunk at [r1835780|https://svn.apache.org/r1835780]. Would backport to 1.8 branch after a few cycles of testing.

> Suggest directory update doesn't close AnalyzingInfixSuggester after building
> -----------------------------------------------------------------------------
>
>                 Key: OAK-7630
>                 URL: https://issues.apache.org/jira/browse/OAK-7630
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.8.0
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.10, 1.9.6, 1.8.6
>
>
> {{SuggestHelper#updateSuggester}} updates suggester by doing a {{build()}} on a newly created instance of {{AnalyzingInfixSuggester}}. But it never closes the suggester instance, which, in turn, leads to un-closed reader. With FS based directory (when copy-on-write is enabled), this leads to leaking file handles. FSDirectory does get closed on GC though.
> The issue was reported by [~mreutegg]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)