You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:35:23 UTC
[GitHub] [guacamole-client] necouchman opened a new pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
necouchman opened a new pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572
This bumps impacted client components to version `1.3.0`. Of note for this:
* There were changes to both `guacamole-common` and `guacamole-common-js`, so they get bumped up to `1.3.0`
* There were no changes at all to `guacamole-auth-header`, including the pending change requests for the last of the issues.
* There are no committed changes to `guacamole-auth-ldap` or `guacamole-auth-saml`; however, because there are pending pull requests for those for translation fixes, I went ahead and bumped up the version numbers.
Let me know if I missed anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572#issuecomment-721421349
> Depending on whether there are pending changes for guacamole-auth-saml, it looks like that shouldn't have been bumped, either.
The Catalan add in #513 impacted the SAML extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572#issuecomment-721410898
> I think some changes are missing for guacamole-auth-header: ...
_Almost_ never mind. I was wrong on guacamole-auth-header having been touched (see apache/guacamole-manual#150), but that being the case its guacamole-ext dependency shouldn't have been updated here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572#issuecomment-721455918
> Ah, for some reason I thought we'd still want to rev the guacamole-ext version used by it, but makes sense.
Probably habit from past releases. In the pre-1.x days, we definitely needed to bump guacamole-ext each release or the extensions would be broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper merged pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #572: GUACAMOLE-1205: Bump Guacamole Client components to version 1.3.0
Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #572:
URL: https://github.com/apache/guacamole-client/pull/572#issuecomment-721421164
> Almost never mind. I was wrong on guacamole-auth-header having been touched (see apache/guacamole-manual#150), but that being the case its guacamole-ext dependency shouldn't have been updated here.
Ah, for some reason I thought we'd still want to rev the guacamole-ext version used by it, but makes sense. I've removed that change from the commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org