You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/25 11:27:12 UTC

[GitHub] maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#issuecomment-466976594
 
 
   @eolivelli  Thanks for your review.
   - You are right,we should make the UT simple.
   - But IMO the configuration for the startup of zk server(e.g `myid`,`sessionTimeOut`) must really use the `MainThread.start()` to start, to assert whether the bebaviour of server is what we expect.
   look at the example of `testBadPeerAddressInQuorum`,`testMinMaxSessionTimeOut`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services