You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marcintustin <gi...@git.apache.org> on 2016/04/17 17:18:34 UTC
[GitHub] spark pull request: [Spark-14685] Document heritability of localPr...
GitHub user marcintustin opened a pull request:
https://github.com/apache/spark/pull/12455
[Spark-14685] Document heritability of localProperties
## What changes were proposed in this pull request?
This updates the java-/scala- doc for setLocalProperty to document heritability of localProperties. This also adds tests for that behaviour.
## How was this patch tested?
Tests pass. New tests were added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marcintustin/spark SPARK-14685
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12455
----
commit aecb305577a7d16065738afcf4bbeee6397b4f53
Author: Marcin Tustin <ma...@gmail.com>
Date: 2016-04-16T23:41:22Z
[SPARK-14685] Document inheritability of localProperties
commit 9964e2e937718194521c6705ba345deba11f1f3d
Author: Marcin Tustin <ma...@gmail.com>
Date: 2016-04-17T14:49:51Z
Add test for heritability of local properties
commit b96cde118c1265bf37ac7036581b8bb1bef80ee0
Author: Marcin Tustin <ma...@gmail.com>
Date: 2016-04-17T15:09:38Z
SPARK-14685 add test to ensure no crosstalk between threads on localProperties
Work with me in NYC: https://www.handy.com/careers/73115?gh_jid=73115&gh_src=o5qcxn
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211124248
**[Test build #2801 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2801/consoleFull)** for PR 12455 at commit [`b96cde1`](https://github.com/apache/spark/commit/b96cde118c1265bf37ac7036581b8bb1bef80ee0).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-216422297
Thanks - merging in master / branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] Document heritability of localPr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211043141
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-213039330
**[Test build #2847 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2847/consoleFull)** for PR 12455 at commit [`b96cde1`](https://github.com/apache/spark/commit/b96cde118c1265bf37ac7036581b8bb1bef80ee0).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-213093342
**[Test build #2847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2847/consoleFull)** for PR 12455 at commit [`b96cde1`](https://github.com/apache/spark/commit/b96cde118c1265bf37ac7036581b8bb1bef80ee0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by marcintustin <gi...@git.apache.org>.
Github user marcintustin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211060379
@JoshRosen This may well be of interest. As mentioned above, my enhancement PR is pending (running tests right now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-213039201
Thanks - let's merge this first once Jenkins pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by marcintustin <gi...@git.apache.org>.
Github user marcintustin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-212673073
@rxin Are you cool to go ahead with this before we resolve the deal on #12456?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by marcintustin <gi...@git.apache.org>.
Github user marcintustin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-216422062
@rxin Tests have passed, can we merge? This still seems low risk for Spark-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by marcintustin <gi...@git.apache.org>.
Github user marcintustin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211164186
The test failures are probably bogus, as per http://mail-archives.apache.org/mod_mbox/spark-dev/201604.mbox/%3CCAMFhwAYRbN0yJGwzvrY8atzS9CCudzioF%3DbcGogCwPq3gPC6Uw%40mail.gmail.com%3E
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] [CORE] Document heritability of ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211135488
**[Test build #2801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2801/consoleFull)** for PR 12455 at commit [`b96cde1`](https://github.com/apache/spark/commit/b96cde118c1265bf37ac7036581b8bb1bef80ee0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-14685] Document heritability of localPr...
Posted by marcintustin <gi...@git.apache.org>.
Github user marcintustin commented on the pull request:
https://github.com/apache/spark/pull/12455#issuecomment-211042961
@rxin Documentation and tests PR. Enhancement PR to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org