[GitHub] [lucene] mocobeta commented on pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

[GitBox <gi...@apache.org>]

mocobeta commented on PR #805:
URL: https://github.com/apache/lucene/pull/805#issuecomment-1094989501

   I took the same bottom-up approach as https://issues.apache.org/jira/browse/LUCENE-10393 here again (determine the duplicate code and sort out the interfaces).
   I'll look through this again but - some private/package-private members have to be made public/protected at this moment. Once we further distill the `backtrace()` and n-best logic and move it to analysis-common from kuromoji/nori, they can be private again; I hope (and believe) it can be possible but I'd leave it for future examination.
   
   I tried but couldn't break it up into smaller patches... I will keep open this for waiting for feedback. Hope these changes make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org