You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/11 09:22:40 UTC

[GitHub] [incubator-kyuubi] simon824 opened a new pull request #1210: [KYUUBI #1039][FOLLOWUP] Application stop log redirect append to engineLog

simon824 opened a new pull request #1210:
URL: https://github.com/apache/incubator-kyuubi/pull/1210


   ### _Why are the changes needed?_
   Now application stop log will overwrite log file `engineLog`, which cause engine logs are lost.
   ![image](https://user-images.githubusercontent.com/18065113/136765514-6a41d2ce-d3df-4b9b-a6d1-5c9bb51a8e4d.png)
   This pr change `overwrite` to `append`.
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1210: [KYUUBI #1039][FOLLOWUP] Application stop log redirect append to engineLog

Posted by GitBox <gi...@apache.org>.

ulysses-you closed pull request #1210:
URL: https://github.com/apache/incubator-kyuubi/pull/1210


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1210: [KYUUBI #1039][FOLLOWUP] Application stop log redirect append to engineLog

Posted by GitBox <gi...@apache.org>.

ulysses-you commented on pull request #1210:
URL: https://github.com/apache/incubator-kyuubi/pull/1210#issuecomment-940613046


   thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org