You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2017/07/28 22:15:21 UTC
logging-log4j2 git commit: [LOG4J2-1071] Allow for bufferSize=0 in
SMTP appender. Add tests.
Repository: logging-log4j2
Updated Branches:
refs/heads/master f56b284a5 -> bc3e711d3
[LOG4J2-1071] Allow for bufferSize=0 in SMTP appender. Add tests.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/bc3e711d
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/bc3e711d
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/bc3e711d
Branch: refs/heads/master
Commit: bc3e711d3e68deb0ebf2a83ea3cdf6929ee68217
Parents: f56b284
Author: Gary Gregory <gg...@apache.org>
Authored: Fri Jul 28 15:15:19 2017 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Fri Jul 28 15:15:19 2017 -0700
----------------------------------------------------------------------
.../log4j/core/util/CyclicBufferTest.java | 50 +++++++++++++++++++-
1 file changed, 49 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/bc3e711d/log4j-core/src/test/java/org/apache/logging/log4j/core/util/CyclicBufferTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/CyclicBufferTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/CyclicBufferTest.java
index a165c8b..e4e1972 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/util/CyclicBufferTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/util/CyclicBufferTest.java
@@ -1,5 +1,6 @@
package org.apache.logging.log4j.core.util;
+import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
@@ -8,7 +9,48 @@ import org.junit.Test;
public class CyclicBufferTest {
@Test
- public void testCyclicBuffer() {
+ public void testSize0() {
+ final CyclicBuffer<Integer> buffer = new CyclicBuffer<>(Integer.class, 0);
+
+ assertTrue(buffer.isEmpty());
+ buffer.add(1);
+ assertTrue(buffer.isEmpty());
+ Integer[] items = buffer.removeAll();
+ assertTrue("Incorrect number of items", items.length == 0);
+
+ assertTrue(buffer.isEmpty());
+ buffer.add(1);
+ buffer.add(2);
+ buffer.add(3);
+ buffer.add(4);
+ items = buffer.removeAll();
+ assertTrue("Incorrect number of items", items.length == 0);
+ assertTrue(buffer.isEmpty());
+ }
+
+ @Test
+ public void testSize1() {
+ final CyclicBuffer<Integer> buffer = new CyclicBuffer<>(Integer.class, 1);
+
+ assertTrue(buffer.isEmpty());
+ buffer.add(1);
+ assertFalse(buffer.isEmpty());
+ Integer[] items = buffer.removeAll();
+ assertTrue("Incorrect number of items", items.length == 1);
+
+ assertTrue(buffer.isEmpty());
+ buffer.add(1);
+ buffer.add(2);
+ buffer.add(3);
+ buffer.add(4);
+ items = buffer.removeAll();
+ assertTrue("Incorrect number of items", items.length == 1);
+ assertArrayEquals(new Integer[] { 4 }, items);
+ assertTrue(buffer.isEmpty());
+ }
+
+ @Test
+ public void testSize3() {
final CyclicBuffer<Integer> buffer = new CyclicBuffer<>(Integer.class, 3);
assertTrue(buffer.isEmpty());
@@ -24,7 +66,13 @@ public class CyclicBufferTest {
buffer.add(4);
items = buffer.removeAll();
assertTrue("Incorrect number of items", items.length == 3);
+ assertArrayEquals(new Integer[] { 2, 3, 4 }, items);
assertTrue(buffer.isEmpty());
}
+ @Test(expected = IllegalArgumentException.class)
+ public void testSizeNegative() {
+ final CyclicBuffer<Integer> buffer = new CyclicBuffer<>(Integer.class, -1);
+ }
+
}