You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by jk...@apache.org on 2014/07/29 10:36:32 UTC

git commit: TAP5-2359: triggering the submit event on the form already submits it, calling its submit method submits it again

Repository: tapestry-5
Updated Branches:
  refs/heads/master 74a066eb7 -> b25c8cde5


TAP5-2359: triggering the submit event on the form already submits it, calling its submit method submits it again


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/b25c8cde
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/b25c8cde
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/b25c8cde

Branch: refs/heads/master
Commit: b25c8cde5026b3c9d2f923b0afdac4d6058798cf
Parents: 74a066e
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Tue Jul 29 10:31:09 2014 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Tue Jul 29 10:31:09 2014 +0200

----------------------------------------------------------------------
 .../src/main/coffeescript/META-INF/modules/t5/core/forms.coffee   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b25c8cde/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
index c20714a..fb69d9e 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
@@ -185,8 +185,7 @@ define ["./events", "./dom", "underscore"],
       # Now the ugly part; if we just invoke submit() on the form, it does not trigger
       # the form's "submit" event, which we need.
 
-      if form.trigger "submit"
-        form.element.submit()
+      form.trigger "submit"
 
       # And cancel the default behavior for the original click event
       return false