You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/08/29 17:09:58 UTC
[GitHub] [druid] paul-rogers commented on a diff in pull request #12957: Building druid-it-tools and running for travis in it.sh
paul-rogers commented on code in PR #12957:
URL: https://github.com/apache/druid/pull/12957#discussion_r957587884
##########
it.sh:
##########
@@ -18,17 +18,20 @@
# Utility script for running the new integration tests, since the Maven
# commands are unwieldy.
+set -e
export DRUID_DEV=$(cd $(dirname $0) && pwd)
function usage
{
- cat <<EOF
+ cat <<EOF
Review Comment:
What is our standard indentation in scripts? It is 2 in Java. I think I saw it as 4 in other scripts, though I might be mistaken.
##########
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/config/ClusterConfigTest.java:
##########
@@ -85,15 +79,6 @@ public void testYaml() throws FileNotFoundException
assertEquals("http://localhost:8888", service.clientUrl());
assertEquals("http://localhost:8888", resolved.routerUrl());
Review Comment:
Can I ask you to comment this out and not remove it? The functionality needs to be tested; let's not use the code itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org