You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/07 07:56:17 UTC

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1411: IGNITE-17871 JDKMarshaller replaced with OptimizedMarshaller for RAFT commands.

tkalkirill commented on code in PR #1411:
URL: https://github.com/apache/ignite-3/pull/1411#discussion_r1041869693


##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/counter/GetValueCommand.java:
##########
@@ -18,9 +18,14 @@
 package org.apache.ignite.raft.server.counter;
 
 import org.apache.ignite.internal.raft.ReadCommand;
+import org.apache.ignite.network.annotations.Transferable;
 
 /**
  * Get a value command.
  */
-public class GetValueCommand implements ReadCommand {
+@Transferable(1_000)

Review Comment:
   We do not have a single place where all types of messages?



##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -113,6 +114,9 @@ public class JraftServerImpl implements RaftServer {
     /** Request executor. */
     private ExecutorService requestExecutor;
 
+    /** Marshaller. */

Review Comment:
   Marshaller for what?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org